From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Filip Hejsek <filip.hejsek@gmail.com>
Cc: qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Laurent Vivier" <lvivier@redhat.com>,
"Amit Shah" <amit@kernel.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Yanan Wang" <wangyanan55@huawei.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Maximilian Immanuel Brandtner" <maxbr@linux.ibm.com>
Subject: Re: [PATCH RFC v5 11/12] ui/console-vc: forward text console size to vc chardev
Date: Mon, 22 Sep 2025 09:41:02 +0100 [thread overview]
Message-ID: <aNELntNU-8RGUeyp@redhat.com> (raw)
In-Reply-To: <20250921-console-resize-v5-11-89e3c6727060@gmail.com>
On Sun, Sep 21, 2025 at 01:45:41AM +0200, Filip Hejsek wrote:
> Update the vc chardev size when the size of a text console is recomputed.
>
> NOTE: It seems wrong that the dpy_text_resize callback is not called
> when the size is recomputed. I believe this is a bug, although it
> doesn't matter much because the only user of the callback is
> ui/ncurses and it only uses the size of fixed consoles.
>
> Signed-off-by: Filip Hejsek <filip.hejsek@gmail.com>
> ---
> ui/console-vc.c | 3 +++
> 1 file changed, 3 insertions(+)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-09-22 8:41 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-20 23:45 [PATCH RFC v5 00/12] virtio-console: notify about the terminal size Filip Hejsek
2025-09-20 23:45 ` [PATCH RFC v5 01/12] chardev: add cols, rows fields Filip Hejsek
2025-09-22 8:13 ` Daniel P. Berrangé
2025-10-13 5:09 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 02/12] chardev: add CHR_EVENT_RESIZE Filip Hejsek
2025-09-22 8:16 ` Daniel P. Berrangé
2025-10-13 5:11 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 03/12] chardev: add qemu_chr_resize() Filip Hejsek
2025-09-22 8:19 ` Daniel P. Berrangé
2025-10-13 5:12 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 04/12] char-mux: add support for the terminal size Filip Hejsek
2025-09-22 8:21 ` Daniel P. Berrangé
2025-10-13 5:13 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 05/12] main-loop: change the handling of SIGWINCH Filip Hejsek
2025-09-22 8:29 ` Daniel P. Berrangé
2025-10-13 5:13 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 06/12] char-stdio: add support for the terminal size Filip Hejsek
2025-09-22 8:33 ` Daniel P. Berrangé
2025-10-13 5:14 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 07/12] qmp: add chardev-window-size-changed command Filip Hejsek
2025-09-22 6:45 ` Markus Armbruster
2025-09-22 8:52 ` Filip Hejsek
2025-09-22 9:38 ` Markus Armbruster
2025-09-22 8:35 ` Daniel P. Berrangé
2025-10-13 5:18 ` Dominique Martinet
2025-10-13 5:23 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 08/12] virtio-serial-bus: add terminal resize messages Filip Hejsek
2025-09-22 8:53 ` Daniel P. Berrangé
2025-10-13 5:19 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 09/12] virtio-console: notify the guest about terminal resizes Filip Hejsek
2025-09-22 8:45 ` Daniel P. Berrangé
2025-10-13 5:28 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 10/12] char-win-stdio: add support for terminal size Filip Hejsek
2025-09-22 8:38 ` Daniel P. Berrangé
2025-10-13 5:29 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 11/12] ui/console-vc: forward text console size to vc chardev Filip Hejsek
2025-09-22 8:41 ` Daniel P. Berrangé [this message]
2025-10-13 5:29 ` Dominique Martinet
2025-09-20 23:45 ` [PATCH RFC v5 12/12] ui/gtk: forward gtk " Filip Hejsek
2025-09-22 8:41 ` Daniel P. Berrangé
2025-10-13 5:44 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNELntNU-8RGUeyp@redhat.com \
--to=berrange@redhat.com \
--cc=amit@kernel.org \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=eduardo@habkost.net \
--cc=filip.hejsek@gmail.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=maxbr@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).