From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76F7CCAC592 for ; Mon, 22 Sep 2025 14:24:37 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v0hSw-0007uv-JD; Mon, 22 Sep 2025 10:24:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0hSt-0007lk-Ed for qemu-devel@nongnu.org; Mon, 22 Sep 2025 10:24:27 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v0hSo-0007fb-Kt for qemu-devel@nongnu.org; Mon, 22 Sep 2025 10:24:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1758551058; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vpGDXhR+8sjGODDaQkvEEVE1RUMaOAyGH94I4/Mhgwk=; b=MezQxo7+F6v3HL5m7xiTIJdiSBpV48zrs8Vlg3SbkvqsD2n1jcOwMnB9H8Go3NXow6/9mo qkbirOvbpKF5a+FoXmuA/dGN6HNWhyhjKbJcFuE3O7TVvW38MtHlSrEh6nzW5Ubb038e2o /U1aXe1j7m6puD8HKWiZTNY3rr59PNE= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-XaAcrw4DPuqBddI2am1saw-1; Mon, 22 Sep 2025 10:24:15 -0400 X-MC-Unique: XaAcrw4DPuqBddI2am1saw-1 X-Mimecast-MFC-AGG-ID: XaAcrw4DPuqBddI2am1saw_1758551054 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 78255180029A for ; Mon, 22 Sep 2025 14:24:14 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.69]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E39AC1800452; Mon, 22 Sep 2025 14:24:12 +0000 (UTC) Date: Mon, 22 Sep 2025 15:24:09 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Igor Mammedov Cc: qemu-devel@nongnu.org, mst@redhat.com Subject: Re: [PATCH] x86: ich9: fix default value of 'No Reboot' bit in GCS Message-ID: References: <20250922132600.562193-1-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250922132600.562193-1-imammedo@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Sep 22, 2025 at 03:26:00PM +0200, Igor Mammedov wrote: > [2] initialized 'No Reboot' bit to 1 by default. And due to quirk it happened > to work with linux iTCO_wdt driver (which clears it on module load). > > However spec [1] states: > " > R/W. This bit is set when the “No Reboot” strap (SPKR pin on > ICH9) is sampled high on PWROK. > " > > So it should be set only when '-global ICH9-LPC.noreboot=true' and cleared > when it's false (which should be default). > > Fix it to behave according to spec and set 'No Reboot' bit only when > '-global ICH9-LPC.noreboot=true'. Is there a real-world problem you hit that is being solved by this change, or is it just a theoretical spec compliance fix ? > > 1) > Intel I/O Controller Hub 9 (ICH9) Family Datasheet (rev: 004) > 2) > Fixes: 920557971b6 (ich9: add TCO interface emulation) > Signed-off-by: Igor Mammedov > --- > include/hw/southbridge/ich9.h | 2 +- > hw/isa/lpc_ich9.c | 7 ++++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > > diff --git a/include/hw/southbridge/ich9.h b/include/hw/southbridge/ich9.h > index 1e231e89c9..2c35dd0484 100644 > --- a/include/hw/southbridge/ich9.h > +++ b/include/hw/southbridge/ich9.h > @@ -95,7 +95,7 @@ struct ICH9LPCState { > #define ICH9_CC_OIC 0x31FF > #define ICH9_CC_OIC_AEN 0x1 > #define ICH9_CC_GCS 0x3410 > -#define ICH9_CC_GCS_DEFAULT 0x00000020 > +#define ICH9_CC_GCS_DEFAULT 0x00000000 > #define ICH9_CC_GCS_NO_REBOOT (1 << 5) > > /* D28:F[0-5] */ > diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c > index 304dffac32..c9cb8f7779 100644 > --- a/hw/isa/lpc_ich9.c > +++ b/hw/isa/lpc_ich9.c > @@ -132,6 +132,11 @@ static void ich9_cc_init(ICH9LPCState *lpc) > static void ich9_cc_reset(ICH9LPCState *lpc) > { > uint8_t *c = lpc->chip_config; > + uint32_t gcs = ICH9_CC_GCS_DEFAULT; > + > + if (lpc->pin_strap.spkr_hi) { > + gcs |= ICH9_CC_GCS_NO_REBOOT; > + } > > memset(lpc->chip_config, 0, sizeof(lpc->chip_config)); > > @@ -142,7 +147,7 @@ static void ich9_cc_reset(ICH9LPCState *lpc) > pci_set_long(c + ICH9_CC_D27IR, ICH9_CC_DIR_DEFAULT); > pci_set_long(c + ICH9_CC_D26IR, ICH9_CC_DIR_DEFAULT); > pci_set_long(c + ICH9_CC_D25IR, ICH9_CC_DIR_DEFAULT); > - pci_set_long(c + ICH9_CC_GCS, ICH9_CC_GCS_DEFAULT); > + pci_set_long(c + ICH9_CC_GCS, gcs); > > ich9_cc_update(lpc); > } > -- > 2.47.3 > > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|