qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: Michael Tokarev <mjt@tls.msk.ru>,
	qemu-devel@nongnu.org, qemu-stable@nongnu.org,
	John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 7.2.x] use fedora:37 for python container instead of :latest
Date: Fri, 26 Sep 2025 10:39:14 +0100	[thread overview]
Message-ID: <aNZfQvXWo55KiUYh@redhat.com> (raw)
In-Reply-To: <edb2826b-f513-44d3-a028-e1278a3dd524@linaro.org>

On Fri, Sep 26, 2025 at 11:36:34AM +0200, Philippe Mathieu-Daudé wrote:
> On 26/9/25 10:25, Daniel P. Berrangé wrote:
> > On Fri, Sep 26, 2025 at 10:31:19AM +0300, Michael Tokarev wrote:
> > > More recent fedora does not have our minimum python versions
> > > anymore.  Stick with the most common fedora version used in
> > > 7.2.x in other places, which is 37.  This way, python tests
> > > works again.
> 
> Valid change, so:
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> 
> > > 
> > > This is a 7.2-specific change, not aimed for the master branch.
> 
> Why? We already learnt using 'latest' tag in docker image is a pain
> to maintain, and hinder reproducibility. Personally I'd rather this
> patch in our /master branch.

Yes, we should change master too, but master will want something
much newer than Fedora 37, so this change for old stable is still
desirable as-is, as a newer Fedora won't be suitable for old
stable.

> > > Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> > > ---
> > >   tests/docker/dockerfiles/python.docker | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



      reply	other threads:[~2025-09-26  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26  7:31 [PATCH 7.2.x] use fedora:37 for python container instead of :latest Michael Tokarev
2025-09-26  8:25 ` Daniel P. Berrangé
2025-09-26  9:36   ` Philippe Mathieu-Daudé
2025-09-26  9:39     ` Daniel P. Berrangé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNZfQvXWo55KiUYh@redhat.com \
    --to=berrange@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=mjt@tls.msk.ru \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).