From: Peter Xu <peterx@redhat.com>
To: Arun Menon <armenon@redhat.com>
Cc: qemu-devel@nongnu.org, "Fabiano Rosas" <farosas@suse.de>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Akihiko Odaki" <odaki@rsg.ci.i.u-tokyo.ac.jp>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Christian Borntraeger" <borntraeger@linux.ibm.com>,
"Matthew Rosato" <mjrosato@linux.ibm.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"David Hildenbrand" <david@redhat.com>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Fam Zheng" <fam@euphon.net>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Cédric Le Goater" <clg@redhat.com>,
"Steve Sistare" <steven.sistare@oracle.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
"Hailiang Zhang" <zhanghailiang@xfusion.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
qemu-arm@nongnu.org
Subject: Re: [PATCH v14 25/27] migration: Rename post_save() to cleanup_save() and make it void
Date: Mon, 29 Sep 2025 14:50:45 -0400 [thread overview]
Message-ID: <aNrVBYf4FP82ZTha@x1.local> (raw)
In-Reply-To: <20250918-propagate_tpm_error-v14-25-36f11a6fb9d3@redhat.com>
On Thu, Sep 18, 2025 at 08:53:42PM +0530, Arun Menon wrote:
> The post_save() function call is responsible for cleaning up resources
> after the device state has been saved.
> Currently it is infallible, and does not return an error.
>
> It is called regardless of whether there is a preceding error from
> save or subsection save. That is, save and post_save() together are
> considered to be an atomic logical operation.
>
> It should not be confused as a counterpart of the post_load() function
> because post_load() does some sanity checks and returns an error if it
> fails. This commit, therefore, renames post_save() to cleanup_save()
> and makes it a void function.
>
> Reviewed-by: Fabiano Rosas <farosas@suse.de>
> Suggested-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
> Signed-off-by: Arun Menon <armenon@redhat.com>
I'll need to drop this one patch because it breaks Rust. Please feel free
to send it separately or just leave post_save() as-is for now.
PS: IMHO post_save() is still a good name to me, pairing well with
pre_save() and all *_load*() functions too. Dropping the retval should
already imply it cannot fail with/without a name change (and also because
modules can do more than "cleanups" in post_save()..).
--
Peter Xu
next prev parent reply other threads:[~2025-09-29 18:52 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 15:23 [PATCH v14 00/27] migration: propagate vTPM errors using Error objects Arun Menon
2025-09-18 15:23 ` [PATCH v14 01/27] migration: push Error **errp into vmstate_subsection_load() Arun Menon
2025-09-18 15:23 ` [PATCH v14 02/27] migration: push Error **errp into vmstate_load_state() Arun Menon
2025-09-18 15:23 ` [PATCH v14 03/27] migration: push Error **errp into qemu_loadvm_state_header() Arun Menon
2025-09-18 15:23 ` [PATCH v14 04/27] migration: push Error **errp into vmstate_load() Arun Menon
2025-09-18 15:23 ` [PATCH v14 05/27] migration: push Error **errp into loadvm_process_command() Arun Menon
2025-09-18 15:23 ` [PATCH v14 06/27] migration: push Error **errp into loadvm_handle_cmd_packaged() Arun Menon
2025-09-18 15:23 ` [PATCH v14 07/27] migration: push Error **errp into qemu_loadvm_state() Arun Menon
2025-09-18 15:23 ` [PATCH v14 08/27] migration: push Error **errp into qemu_load_device_state() Arun Menon
2025-09-18 15:23 ` [PATCH v14 09/27] migration: push Error **errp into qemu_loadvm_state_main() Arun Menon
2025-09-18 15:23 ` [PATCH v14 10/27] migration: push Error **errp into qemu_loadvm_section_start_full() Arun Menon
2025-09-18 15:23 ` [PATCH v14 11/27] migration: push Error **errp into qemu_loadvm_section_part_end() Arun Menon
2025-09-18 15:23 ` [PATCH v14 12/27] migration: Update qemu_file_get_return_path() docs and remove dead checks Arun Menon
2025-09-18 15:23 ` [PATCH v14 13/27] migration: make loadvm_postcopy_handle_resume() void Arun Menon
2025-09-18 15:23 ` [PATCH v14 14/27] migration: push Error **errp into ram_postcopy_incoming_init() Arun Menon
2025-09-18 15:23 ` [PATCH v14 15/27] migration: push Error **errp into loadvm_postcopy_handle_advise() Arun Menon
2025-09-18 15:23 ` [PATCH v14 16/27] migration: push Error **errp into loadvm_postcopy_handle_listen() Arun Menon
2025-09-18 15:23 ` [PATCH v14 17/27] migration: push Error **errp into loadvm_postcopy_handle_run() Arun Menon
2025-09-18 15:23 ` [PATCH v14 18/27] migration: push Error **errp into loadvm_postcopy_ram_handle_discard() Arun Menon
2025-09-18 15:23 ` [PATCH v14 19/27] migration: push Error **errp into loadvm_handle_recv_bitmap() Arun Menon
2025-09-18 15:23 ` [PATCH v14 20/27] migration: Return -1 on memory allocation failure in ram.c Arun Menon
2025-09-18 15:23 ` [PATCH v14 21/27] migration: push Error **errp into loadvm_process_enable_colo() Arun Menon
2025-09-18 15:23 ` [PATCH v14 22/27] migration: push Error **errp into loadvm_postcopy_handle_switchover_start() Arun Menon
2025-09-18 15:23 ` [PATCH v14 23/27] migration: Capture error in postcopy_ram_listen_thread() Arun Menon
2025-09-18 15:23 ` [PATCH v14 24/27] migration: Remove error variant of vmstate_save_state() function Arun Menon
2025-09-18 15:23 ` [PATCH v14 25/27] migration: Rename post_save() to cleanup_save() and make it void Arun Menon
2025-09-29 18:50 ` Peter Xu [this message]
2025-09-30 4:29 ` Arun Menon
2025-09-30 16:08 ` Peter Xu
2025-09-18 15:23 ` [PATCH v14 26/27] migration: Add error-parameterized function variants in VMSD struct Arun Menon
2025-09-18 15:23 ` [PATCH v14 27/27] backends/tpm: Propagate vTPM error on migration failure Arun Menon
2025-09-19 12:05 ` [PATCH v14 00/27] migration: propagate vTPM errors using Error objects Akihiko Odaki
2025-09-29 8:49 ` Arun Menon
2025-09-29 13:46 ` Peter Xu
2025-09-29 14:30 ` Fabiano Rosas
2025-09-29 15:25 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNrVBYf4FP82ZTha@x1.local \
--to=peterx@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=alex.williamson@redhat.com \
--cc=armenon@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=dmitry.osipenko@collabora.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=farosas@suse.de \
--cc=harshpb@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=npiggin@gmail.com \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=steven.sistare@oracle.com \
--cc=thuth@redhat.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).