qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Steven Sistare <steven.sistare@oracle.com>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
	Markus Armbruster <armbru@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Eric Blake <eblake@redhat.com>,
	"Dr. David Alan Gilbert" <dave@treblig.org>,
	Cedric Le Goater <clg@redhat.com>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [PATCH V4 0/8] Live update: cpr-exec
Date: Tue, 30 Sep 2025 16:40:26 -0400	[thread overview]
Message-ID: <aNxAOmEMb8-zTYvM@x1.local> (raw)
In-Reply-To: <9ce21a1c-5e0b-4d57-bc9e-1cb5bf978ee7@oracle.com>

On Tue, Sep 30, 2025 at 03:49:12PM -0400, Steven Sistare wrote:
> On 9/30/2025 12:42 PM, Peter Xu wrote:
> > On Tue, Sep 30, 2025 at 11:28:58AM -0400, Steven Sistare wrote:
> > > Just a reminder, these patches still need review from Peter and/or Fabiano:
> > > 
> > >    Patch 5/8: migration: cpr-exec save and load
> > >    Patch 6/8: migration: cpr-exec mode
> > 
> > I read them and left some comments where I have.  For patch 5 please
> > remember to include the header that Cedric pointed out, because it does
> > break the builds.
> > 
> > Other than that the series looks OK.  I suggest when you repost, have the
> > testcases be together.  I saw Fabiano queued most of the test patches, but
> > it shouldn't be an issue no matter which lands first.
> 
> If I post V5 with the patch "cpr-exec test", and it lands before the
> other test patches, then V5 will not build.  "cpr-exec test" depends on
> a handful of new test functions.

I meant the repost needs to include all the dependency test patches too, no
matter whether Fabiano will already have sent a pull.

-- 
Peter Xu



      reply	other threads:[~2025-09-30 20:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 13:49 [PATCH V4 0/8] Live update: cpr-exec Steve Sistare
2025-09-22 13:49 ` [PATCH V4 1/8] migration: multi-mode notifier Steve Sistare
2025-09-22 15:18   ` Cédric Le Goater
2025-09-24 18:15     ` Steven Sistare
2025-09-22 13:49 ` [PATCH V4 2/8] migration: add cpr_walk_fd Steve Sistare
2025-09-22 13:49 ` [PATCH V4 3/8] oslib: qemu_clear_cloexec Steve Sistare
2025-09-22 13:49 ` [PATCH V4 4/8] migration: cpr-exec-command parameter Steve Sistare
2025-09-22 13:49 ` [PATCH V4 5/8] migration: cpr-exec save and load Steve Sistare
2025-09-22 16:00   ` Cédric Le Goater
2025-09-24 18:16     ` Steven Sistare
2025-09-25  7:11       ` Cédric Le Goater
2025-09-25 20:38         ` Steven Sistare
2025-09-30 16:19         ` Peter Xu
2025-09-30 16:39           ` Steven Sistare
2025-09-22 13:49 ` [PATCH V4 6/8] migration: cpr-exec mode Steve Sistare
2025-09-22 15:28   ` Cédric Le Goater
2025-09-24 18:16     ` Steven Sistare
2025-09-25  7:12       ` Cédric Le Goater
2025-09-30 16:39   ` Peter Xu
2025-09-30 17:18     ` Steven Sistare
2025-09-30 18:20       ` Peter Xu
2025-09-30 18:29         ` Steven Sistare
2025-09-22 13:49 ` [PATCH V4 7/8] migration: cpr-exec docs Steve Sistare
2025-09-22 13:49 ` [PATCH V4 8/8] vfio: cpr-exec mode Steve Sistare
2025-09-22 15:28   ` Cédric Le Goater
2025-09-30 15:28 ` [PATCH V4 0/8] Live update: cpr-exec Steven Sistare
2025-09-30 16:42   ` Peter Xu
2025-09-30 16:52     ` Steven Sistare
2025-09-30 19:49     ` Steven Sistare
2025-09-30 20:40       ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aNxAOmEMb8-zTYvM@x1.local \
    --to=peterx@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=clg@redhat.com \
    --cc=dave@treblig.org \
    --cc=eblake@redhat.com \
    --cc=farosas@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=steven.sistare@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).