From: Kevin Wolf <kwolf@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>
Subject: Re: [PATCH] iotests: Adjust nbd expected outputs to match current behavior
Date: Tue, 14 Oct 2025 08:42:40 +0200 [thread overview]
Message-ID: <aO3w4NoXneWRPSHQ@redhat.com> (raw)
In-Reply-To: <20251013213638.494193-2-eblake@redhat.com>
Am 13.10.2025 um 23:36 hat Eric Blake geschrieben:
> 'git bisect' confirms that the NBD iotests 94 and 119 have been broken
> since commit effd60c8 in v9.0.0; but as Dan Berrange's efforts to
> improve CI have proven, we haven't been reliably running them to
> notice. The change was good (moving coroutine commands to run in the
> right context), but it meant that "execute":"quit" now waits to
> complete until the coroutines tearing down NBD have first reported the
> SHUTDOWN event, in the opposite order of what happened pre-patch.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Fixes: effd60c8 ("monitor: only run coroutine commands in qemu_aio_context", v9.0.0)
> Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2025-10-14 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 21:36 [PATCH] iotests: Adjust nbd expected outputs to match current behavior Eric Blake
2025-10-14 6:42 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO3w4NoXneWRPSHQ@redhat.com \
--to=kwolf@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).