From: "Daniel P. Berrangé" <berrange@redhat.com>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com,
"Gerd Hoffmann" <kraxel@redhat.com>,
"reviewer:Incompatible changes" <devel@lists.libvirt.org>,
"Dr. David Alan Gilbert" <dave@treblig.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v2] RFC: audio: deprecate HMP audio commands
Date: Wed, 15 Oct 2025 10:33:02 +0100 [thread overview]
Message-ID: <aO9qTkR8xik0iYVE@redhat.com> (raw)
In-Reply-To: <20251015092851.2850617-1-marcandre.lureau@redhat.com>
On Wed, Oct 15, 2025 at 01:28:51PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> The command is niche and better served by the host audio system.
> There is no QMP equivalent, fortunately. You can capture the audio
> stream via remote desktop protocols too (dbus, vnc, spice).
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> docs/about/deprecated.rst | 20 ++++++++++++++++++++
> meson.build | 4 ++++
> audio/audio-hmp-cmds.c | 7 +++++++
> audio/meson.build | 5 +++--
> hmp-commands-info.hx | 2 ++
> hmp-commands.hx | 2 ++
> 6 files changed, 38 insertions(+), 2 deletions(-)
Please remove the build system changes, as that is not something that
is done with deprecation.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-10-15 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 9:28 [PATCH v2] RFC: audio: deprecate HMP audio commands marcandre.lureau
2025-10-15 9:33 ` Daniel P. Berrangé [this message]
2025-10-15 9:43 ` Marc-André Lureau
2025-10-15 9:46 ` Daniel P. Berrangé
2025-10-15 13:24 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aO9qTkR8xik0iYVE@redhat.com \
--to=berrange@redhat.com \
--cc=dave@treblig.org \
--cc=devel@lists.libvirt.org \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).