Re: [PATCH v2] RFC: audio: deprecate HMP audio commands

["Daniel P. Berrangé" <berrange@redhat.com>]

On Wed, Oct 15, 2025 at 01:43:29PM +0400, Marc-André Lureau wrote:
> Hi Daniel
> 
> On Wed, Oct 15, 2025 at 1:33 PM Daniel P. Berrangé <berrange@redhat.com>
> wrote:
> 
> > On Wed, Oct 15, 2025 at 01:28:51PM +0400, marcandre.lureau@redhat.com
> > wrote:
> > > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> > >
> > > The command is niche and better served by the host audio system.
> > > There is no QMP equivalent, fortunately. You can capture the audio
> > > stream via remote desktop protocols too (dbus, vnc, spice).
> > >
> > > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > ---
> > >  docs/about/deprecated.rst | 20 ++++++++++++++++++++
> > >  meson.build               |  4 ++++
> > >  audio/audio-hmp-cmds.c    |  7 +++++++
> > >  audio/meson.build         |  5 +++--
> > >  hmp-commands-info.hx      |  2 ++
> > >  hmp-commands.hx           |  2 ++
> > >  6 files changed, 38 insertions(+), 2 deletions(-)
> >
> > Please remove the build system changes, as that is not something that
> > is done with deprecation.
>
> The reason I'd like to have those build system changes is to be able to
> build a version of QEMU without those commands. Furthermore, we can already
> clearly isolate the parts to be removed.

What's the reason to want to build without the commands ? Anyone doing
so will be breaking compatibility which undermines the deprecation process.
We've had these commands for decades, and waiting until the deprecatino
process has run its course looks sufficient.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|