From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB9EBCAC5BB for ; Wed, 8 Oct 2025 09:29:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v6QSs-0006ET-IN; Wed, 08 Oct 2025 05:28:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6QSr-0006E5-1s for qemu-devel@nongnu.org; Wed, 08 Oct 2025 05:28:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6QSo-0006WX-E7 for qemu-devel@nongnu.org; Wed, 08 Oct 2025 05:28:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759915679; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=T0O/bz4QHwLG+QPg7fLvM8jrGzFk3xKxRR6xL0jqPQc=; b=hGmptTXGdheFWhmwrn0gObwVGbK6yJ3/p7g3wCXo2Ke39rZwjVtHlJ06qbVUON/XUWJ36z KKWAB88+KWmd4shFZu1mh9UZo1EHvqkgds6vHJh15amKZh37ejDdn9zo9b84T3OVC1smxz IfKBcmr10pPo//aGW76Xw2lT8EsX7t0= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-320-mHlUsMwCMRO7z7pnCmHS_A-1; Wed, 08 Oct 2025 05:27:56 -0400 X-MC-Unique: mHlUsMwCMRO7z7pnCmHS_A-1 X-Mimecast-MFC-AGG-ID: mHlUsMwCMRO7z7pnCmHS_A_1759915675 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BF6AD180045C; Wed, 8 Oct 2025 09:27:54 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.74]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC8E23002D0D; Wed, 8 Oct 2025 09:27:47 +0000 (UTC) Date: Wed, 8 Oct 2025 10:27:40 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , John Snow , Kevin Wolf , Markus Armbruster , Peter Maydell , Stefan Hajnoczi , Mads Ynddal Subject: Re: [PATCH 1/6] tracetool: rename variable with conflicting types Message-ID: References: <20251008063546.376603-1-pbonzini@redhat.com> <20251008063546.376603-2-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251008063546.376603-2-pbonzini@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.422, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Oct 08, 2025 at 08:35:40AM +0200, Paolo Bonzini wrote: > "backend" is used as both a string and a backend.Wrapper. In preparation > for adding type annotations, use different names. > > Signed-off-by: Paolo Bonzini > --- > scripts/tracetool/__init__.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py > index 74062d21a7c..85527c08c98 100644 > --- a/scripts/tracetool/__init__.py > +++ b/scripts/tracetool/__init__.py > @@ -566,9 +566,9 @@ def generate(events, group, format, backends, > > if len(backends) == 0: > raise TracetoolError("no backends specified") > - for backend in backends: > - if not tracetool.backend.exists(backend): > - raise TracetoolError("unknown backend: %s" % backend) > + for backend_name in backends: > + if not tracetool.backend.exists(backend_name): > + raise TracetoolError("unknown backend: %s" % backend_name) IMHO it suffices to shorten the name 'for name in backends', but either way Reviewed-by: Daniel P. Berrangé > backend = tracetool.backend.Wrapper(backends, format) > > import tracetool.backend.dtrace > -- > 2.51.0 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|