Re: [PATCH 2/6] tracetool: apply isort and add check

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Oct 09, 2025 at 10:22:43AM +0200, Paolo Bonzini wrote:
> On Thu, Oct 9, 2025 at 9:52 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
> > I've proposed removing them in favour of meson rules earlier
> > this year:
> >
> >   https://lists.gnu.org/archive/html/qemu-devel/2025-02/msg04920.html
> 
> I mostly agree with the intent of integrating tests with the
> configure/pyvenv/meson infrastructure, but I'd do things in a
> different order:
> 
> - split part of scripts/ into contrib/scripts/ to identify one-off
> scripts vs. what is really used in the build process

IMHO we should rather aim to eliminate contrib. We should either care
about the contents, and find an appropriate home for it in tree & have
ability to install it, or they should live outside QEMU git in their
own home.

We shouldn't encourage a "dumping ground" for stuff that we don't
know what to do with.

> - move python/scripts/ to scripts/venv/, adjusting python/tests
> 
> - move tests/minreqs.txt to pythondeps.toml. switch from pip to mkvenv
> in tests/Makefile.
> 
> - unifying the test scripts for all of scripts/, as much as possible
> 
> - integrate tests in meson, but keeping the shell scripts for now.
> move python/tests to tests/python. add a custom_target() to do "mkvenv
> ensuregroup tests"
> 
> - move tox usage to .gitlab-ci.d, placing tox outside the configure
> script instead of inside. this makes the QEMU venv a "child" of the
> tox venv rather than the opposite, and allows more testing than just
> running the linters

If tox is outside, that seems to require that we re-run configure for
each different python version we want to run tests with, which feels
pretty undesirable.

There's the (system) python version that we want to run the overall
build system with, and then there are N other python versions which
we want to be able to run linters against.

> - remove testing-related parts of tests/Makefile
> 
> Only then I'd look at opportunities for unifying all the settings and
> moving away from the shell scripts



With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|