From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29F61CCA470 for ; Thu, 9 Oct 2025 08:59:08 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v6mTm-0001ow-S2; Thu, 09 Oct 2025 04:58:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6mTk-0001ld-NT for qemu-devel@nongnu.org; Thu, 09 Oct 2025 04:58:29 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v6mTf-0005B0-VZ for qemu-devel@nongnu.org; Thu, 09 Oct 2025 04:58:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760000301; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Bc2l4y/fRMXy98EnEPtWeJaE5mh6QV7R6DafmVZFBno=; b=Dlku7A72bq/jQRUYrjIGOt4HzHYR73/E+HtgqbvkV3Jk1Dqu3X15oblxFO1UL/yocRfZ8H xd0zKD1FlH7itTi8tl3Z9OAiHBeRT+Y4yo9DnxSwkx9R/4NdaPoD7MIpZBrLYlCA9e45+S LbaftLUkVuptt7ZtMJphSlDKO34XlJQ= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-282-mWEkb8WBNAOPAT-iQJ-j2A-1; Thu, 09 Oct 2025 04:58:17 -0400 X-MC-Unique: mWEkb8WBNAOPAT-iQJ-j2A-1 X-Mimecast-MFC-AGG-ID: mWEkb8WBNAOPAT-iQJ-j2A_1760000296 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B945019560B2; Thu, 9 Oct 2025 08:58:16 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.63]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 76CAF30002C5; Thu, 9 Oct 2025 08:58:12 +0000 (UTC) Date: Thu, 9 Oct 2025 09:58:08 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , John Snow , Kevin Wolf , Markus Armbruster , Peter Maydell , Mads Ynddal Subject: Re: [PATCH 2/6] tracetool: apply isort and add check Message-ID: References: <20251008063546.376603-1-pbonzini@redhat.com> <20251008063546.376603-3-pbonzini@redhat.com> <20251008175811.GB181748@fedora> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.442, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Oct 09, 2025 at 10:22:43AM +0200, Paolo Bonzini wrote: > On Thu, Oct 9, 2025 at 9:52 AM Daniel P. Berrangé wrote: > > I've proposed removing them in favour of meson rules earlier > > this year: > > > > https://lists.gnu.org/archive/html/qemu-devel/2025-02/msg04920.html > > I mostly agree with the intent of integrating tests with the > configure/pyvenv/meson infrastructure, but I'd do things in a > different order: > > - split part of scripts/ into contrib/scripts/ to identify one-off > scripts vs. what is really used in the build process IMHO we should rather aim to eliminate contrib. We should either care about the contents, and find an appropriate home for it in tree & have ability to install it, or they should live outside QEMU git in their own home. We shouldn't encourage a "dumping ground" for stuff that we don't know what to do with. > - move python/scripts/ to scripts/venv/, adjusting python/tests > > - move tests/minreqs.txt to pythondeps.toml. switch from pip to mkvenv > in tests/Makefile. > > - unifying the test scripts for all of scripts/, as much as possible > > - integrate tests in meson, but keeping the shell scripts for now. > move python/tests to tests/python. add a custom_target() to do "mkvenv > ensuregroup tests" > > - move tox usage to .gitlab-ci.d, placing tox outside the configure > script instead of inside. this makes the QEMU venv a "child" of the > tox venv rather than the opposite, and allows more testing than just > running the linters If tox is outside, that seems to require that we re-run configure for each different python version we want to run tests with, which feels pretty undesirable. There's the (system) python version that we want to run the overall build system with, and then there are N other python versions which we want to be able to run linters against. > - remove testing-related parts of tests/Makefile > > Only then I'd look at opportunities for unifying all the settings and > moving away from the shell scripts With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|