qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Hanna Reitz" <hreitz@redhat.com>,
	"Kevin Wolf" <kwolf@redhat.com>,
	qemu-block@nongnu.org
Subject: Re: [PATCH RFC/WIP 4/4] gitlab: add jobs for thorough block tests
Date: Fri, 10 Oct 2025 13:11:49 +0100	[thread overview]
Message-ID: <aOj4BUeUP_PgDLFG@redhat.com> (raw)
In-Reply-To: <996a6f93-9abd-46a1-9647-296983101f00@redhat.com>

On Fri, Oct 10, 2025 at 01:55:28PM +0200, Thomas Huth wrote:
> On 08/10/2025 13.35, Daniel P. Berrangé wrote:
> > CI is only exercising the qcow2 'auto' tests currently. As a result we
> > get no exposure of changes which cause regressions in other block format
> > drivers.
> > 
> > This adds new CI jobs for each block format, that will run the target
> > 'make check-block-$FORMAT'. The jobs are separate so that we have the
> > ability to make each formats gating or not, depending on their level
> > of reliability.
> 
> Some of the jobs seem to be quite quick, though, only 5 minutes and less:
> 
>  https://gitlab.com/berrange/qemu/-/jobs/11633680698
>  https://gitlab.com/berrange/qemu/-/jobs/11633680704
>  https://gitlab.com/berrange/qemu/-/jobs/11633680694
> 
> I think I'd prefer to see them rather merged into one job, to avoid that we
> waste too much time with setting up the container each time. We can still
> sort out flaky parts into separate jobs later if necessary.

The container setup / job prep is not a significant time sink  - just
at the 1 minute mark. I wanted to have separate jobs per backend so
that the pipeline dashboard gives an informative summary of which
block backends are impacted by the change, rather than having to
search the logs to discover it.

Flaky parts shouldn't be separate jobs  - the tests should either be
fixed or removed, because unreliable tests just end up being ignored,
leading to regressions being missed. 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2025-10-10 12:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-08 11:35 [PATCH 0/4] tests: do more testing of block drivers in CI Daniel P. Berrangé
2025-10-08 11:35 ` [PATCH 1/4] tests: print reason when I/O test is skipped in TAP mode Daniel P. Berrangé
2025-10-08 11:47   ` Thomas Huth
2025-10-08 11:35 ` [PATCH 2/4] tests: rearrange suites for I/O tests Daniel P. Berrangé
2025-10-14  8:26   ` Kevin Wolf
2025-10-08 11:35 ` [PATCH 3/4] tests: add nbd and luks to the I/O test suites Daniel P. Berrangé
2025-10-08 11:55   ` Thomas Huth
2025-10-08 12:55     ` Daniel P. Berrangé
2025-10-08 13:03       ` Thomas Huth
2025-10-08 15:55       ` Eric Blake
2025-10-14  8:50         ` Kevin Wolf
2025-10-08 15:49   ` Eric Blake
2025-10-08 11:35 ` [PATCH RFC/WIP 4/4] gitlab: add jobs for thorough block tests Daniel P. Berrangé
2025-10-08 15:57   ` Eric Blake
2025-10-08 16:23     ` Daniel P. Berrangé
2025-10-13 21:46       ` Eric Blake
2025-10-10 11:55   ` Thomas Huth
2025-10-10 12:11     ` Daniel P. Berrangé [this message]
2025-10-08 16:28 ` [PATCH 0/4] tests: do more testing of block drivers in CI Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aOj4BUeUP_PgDLFG@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).