From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C365CAC5BB for ; Fri, 10 Oct 2025 09:32:43 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v79Tt-0000FH-65; Fri, 10 Oct 2025 05:32:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v79To-0000El-VX for qemu-devel@nongnu.org; Fri, 10 Oct 2025 05:32:05 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v79Tj-0008LL-3e for qemu-devel@nongnu.org; Fri, 10 Oct 2025 05:32:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1760088715; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=lq73h9VT7ow+5WKUJr5lygakN7Pxc+KxztV/3drLTQM=; b=OhAVpDUdELiUlWznEJ12P+E7bWTfwS8mTVoWcp5B3B9oWJIfBzAmWKu+GbHGkk9gA9NiCa Hh1UF4+gKZoWrrCT4m1pXgNkvW0CPxBcPSRoFqEbogRc0vL1G0UlCB2FckA551nv3HxlEF vW13Kjt6L0E4ggkCmj/jf3WACz8lH7Y= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-512-xE4WLdtVOsKumcWy4Z9bkA-1; Fri, 10 Oct 2025 05:31:51 -0400 X-MC-Unique: xE4WLdtVOsKumcWy4Z9bkA-1 X-Mimecast-MFC-AGG-ID: xE4WLdtVOsKumcWy4Z9bkA_1760088710 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0383319560B0; Fri, 10 Oct 2025 09:31:50 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.177]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A5F9D1800447; Fri, 10 Oct 2025 09:31:45 +0000 (UTC) Date: Fri, 10 Oct 2025 10:31:41 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, Paolo Bonzini , Yanan Wang , Markus Armbruster , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Fabiano Rosas , Eric Blake , "Dr. David Alan Gilbert" , Laurent Vivier , Marcel Apfelbaum , Zhao Liu , Eduardo Habkost Subject: Re: [PATCH v3] hw/uefi: add "info firmware-log" + "query-firmware-log" monitor commands Message-ID: References: <20251010071008.2555267-1-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.438, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 10, 2025 at 11:27:36AM +0200, Gerd Hoffmann wrote: > > > +static void handle_ovmf_log_range(GString *out, > > > + dma_addr_t start, > > > + dma_addr_t end, > > > + Error **errp) > > > +{ > > > How about eliminating the intermediate buffer alloocation / printf by > > reading straight into the GString buf ? Something like > > > > size_t len = end - start; > > g_string_set_size(out, out->len + len); > > if (dma_memory_read(&address_space_memory, start, > > out->str + (out->len - len), > > len, MEMTXATTRS_UNSPECIFIED)) { > > ... > > } > > There are two ranges in the wrap-around case, and I don't think I can > put multiple chunks into a single gstring. I'm not sure I understand ? The code I've suggest here satisfies the existing API contract you've got for handle_ovmf_log_range, so should be happy with being called multiple times. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|