Re: [PATCH v2 2/2] tests: Evict stale files in the functional download cache after a while

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Oct 13, 2025 at 02:17:19PM +0200, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
> 
> The download cache of the functional tests is currently only growing.
> But sometimes tests get removed or changed to use different assets,
> thus we should clean up the stale old assets after a while when they
> are not in use anymore. So add a script that looks at the time stamps
> of the assets and removes them if they haven't been touched for more
> than half of a year. Since there might also be some assets around that
> have been added to the cache before we added the time stamp files,
> assume a default time stamp that is close to the creation date of this
> patch, so that we don't delete these files too early (so we still have
> all assets around in case we have to bisect an issue in the recent past
> of QEMU).
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS                       |  1 +
>  scripts/clean_functional_cache.py | 45 +++++++++++++++++++++++++++++++
>  tests/Makefile.include            |  1 +
>  3 files changed, 47 insertions(+)
>  create mode 100755 scripts/clean_functional_cache.py

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|