Re: [PATCH v2] block/curl.c: Use explicit long constants in curl_easy_setopt calls

[Kevin Wolf <kwolf@redhat.com>]

[Restored the original Cc: list]

Am 10.10.2025 um 21:03 hat Richard Henderson geschrieben:
> On 10/9/25 07:08, Richard W.M. Jones wrote:
> > curl_easy_setopt takes a variable argument that depends on what
> > CURLOPT you are setting.  Some require a long constant.  Passing a
> > plain int constant is potentially wrong on some platforms.
> > 
> > With warnings enabled, multiple warnings like this were printed:
> > 
> > ../block/curl.c: In function ‘curl_init_state’:
> > ../block/curl.c:474:13: warning: call to ‘_curl_easy_setopt_err_long’ declared with attribute warning: curl_easy_setopt expects a long argument [-Wattribute-warning]
> >    474 |             curl_easy_setopt(state->curl, CURLOPT_AUTOREFERER, 1) ||
> >        |             ^

It would have been good to mention on which platforms/compilers/curl
versions you get the warning (and why only now), because I don't see
this warning even after reverting the commit.

It's too late for the commit message now, but maybe we can at least have
it here, in the mailing list thread associated with the Message-ID in
the commit?

> > Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> > Signed-off-by: Chenxi Mao <maochenxi@bosc.ac.cn>
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> >   block/curl.c               | 10 +++++-----
> >   contrib/elf2dmp/download.c |  4 ++--
> >   2 files changed, 7 insertions(+), 7 deletions(-)
> 
> Thanks.  I directly applied this to master during the last PR batch.

Please don't drop CCs in replies. This is true in general, but even more
so if it's CCs for the maintainers you're bypassing.

Kevin