From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1543CCF9E0 for ; Mon, 27 Oct 2025 10:21:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDKLC-0007qC-MJ; Mon, 27 Oct 2025 06:20:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDKLB-0007pc-As for qemu-devel@nongnu.org; Mon, 27 Oct 2025 06:20:41 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDKL4-0005QA-Cj for qemu-devel@nongnu.org; Mon, 27 Oct 2025 06:20:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761560432; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RoZCprBXgrxWqAl395awxd471CB7fByXhLpd2Z6+CzY=; b=P0fCPasLnCc3x5ZF/5PCPdAs6JF7snKm+PE1qZ2EdqkpMIIlx/GIqSctZPhpUYPPUKZ4nB i5tXmlPjXjsItfD3IXtxIy73uAVyKGv1FcSSSlQUy00yfNjWk7aGI3Kh9jumIForCd0HDT vWW67TCUJUmB1U3DkoZtBhQXM8ho6JM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-166-dBMvKkCpMQONdEoifdFppQ-1; Mon, 27 Oct 2025 06:20:28 -0400 X-MC-Unique: dBMvKkCpMQONdEoifdFppQ-1 X-Mimecast-MFC-AGG-ID: dBMvKkCpMQONdEoifdFppQ_1761560428 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F355A18007EB; Mon, 27 Oct 2025 10:20:27 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.35]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F021A19560AD; Mon, 27 Oct 2025 10:20:25 +0000 (UTC) Date: Mon, 27 Oct 2025 10:20:22 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: qemu-devel@nongnu.org, qemu-stable@nongnu.org Cc: Eduardo Habkost , Paolo Bonzini , Eric Blake Subject: Re: [PULL 12/13] crypto: stop requiring "key encipherment" usage in x509 certs Message-ID: References: <20251024131937.56673-1-berrange@redhat.com> <20251024131937.56673-13-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251024131937.56673-13-berrange@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org This patch is relevant to pick for all stable branches. Not critical, but a "nice to have" fix if it cherry picks cleanly. On Fri, Oct 24, 2025 at 02:19:36PM +0100, Daniel P. Berrangé wrote: > This usage flag was deprecated by RFC8813, such that it is > forbidden to be present for certs using ECDSA/ECDH algorithms, > and in TLS 1.3 is conceptually obsolete. > > As such many valid certs will no longer have this key usage > flag set, and QEMU should not be rejecting them, as this > prevents use of otherwise valid & desirable algorithms. > > Reviewed-by: Eric Blake > Signed-off-by: Daniel P. Berrangé > --- > crypto/tlscredsx509.c | 10 +------- > docs/system/tls.rst | 13 +++------- > tests/unit/crypto-tls-x509-helpers.h | 6 ++--- > tests/unit/test-crypto-tlscredsx509.c | 36 +++++++++++++-------------- > tests/unit/test-crypto-tlssession.c | 14 +++++------ > tests/unit/test-io-channel-tls.c | 4 +-- > 6 files changed, 34 insertions(+), 49 deletions(-) > > diff --git a/crypto/tlscredsx509.c b/crypto/tlscredsx509.c > index e21d85fe16..f26429736c 100644 > --- a/crypto/tlscredsx509.c > +++ b/crypto/tlscredsx509.c > @@ -144,7 +144,7 @@ qcrypto_tls_creds_check_cert_key_usage(QCryptoTLSCredsX509 *creds, > if (status < 0) { > if (status == GNUTLS_E_REQUESTED_DATA_NOT_AVAILABLE) { > usage = isCA ? GNUTLS_KEY_KEY_CERT_SIGN : > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT; > + GNUTLS_KEY_DIGITAL_SIGNATURE; > } else { > error_setg(errp, > "Unable to query certificate %s key usage: %s", > @@ -171,14 +171,6 @@ qcrypto_tls_creds_check_cert_key_usage(QCryptoTLSCredsX509 *creds, > return -1; > } > } > - if (!(usage & GNUTLS_KEY_KEY_ENCIPHERMENT)) { > - if (critical) { > - error_setg(errp, > - "Certificate %s usage does not permit key " > - "encipherment", certFile); > - return -1; > - } > - } > } > > return 0; > diff --git a/docs/system/tls.rst b/docs/system/tls.rst > index e284c82801..a4f6781d62 100644 > --- a/docs/system/tls.rst > +++ b/docs/system/tls.rst > @@ -118,7 +118,6 @@ information for each server, and use it to issue server certificates. > ip_address = 2620:0:cafe::87 > ip_address = 2001:24::92 > tls_www_server > - encryption_key > signing_key > EOF > # certtool --generate-privkey > server-hostNNN-key.pem > @@ -134,9 +133,8 @@ the subject alt name extension data. The ``tls_www_server`` keyword is > the key purpose extension to indicate this certificate is intended for > usage in a web server. Although QEMU network services are not in fact > HTTP servers (except for VNC websockets), setting this key purpose is > -still recommended. The ``encryption_key`` and ``signing_key`` keyword is > -the key usage extension to indicate this certificate is intended for > -usage in the data session. > +still recommended. The ``signing_key`` keyword is the key usage extension > +to indicate this certificate is intended for usage in the data session. > > The ``server-hostNNN-key.pem`` and ``server-hostNNN-cert.pem`` files > should now be securely copied to the server for which they were > @@ -171,7 +169,6 @@ certificates. > organization = Name of your organization > cn = hostNNN.foo.example.com > tls_www_client > - encryption_key > signing_key > EOF > # certtool --generate-privkey > client-hostNNN-key.pem > @@ -187,9 +184,8 @@ the ``dns_name`` and ``ip_address`` fields are not included. The > ``tls_www_client`` keyword is the key purpose extension to indicate this > certificate is intended for usage in a web client. Although QEMU network > clients are not in fact HTTP clients, setting this key purpose is still > -recommended. The ``encryption_key`` and ``signing_key`` keyword is the > -key usage extension to indicate this certificate is intended for usage > -in the data session. > +recommended. The ``signing_key`` keyword is the key usage extension to > +indicate this certificate is intended for usage in the data session. > > The ``client-hostNNN-key.pem`` and ``client-hostNNN-cert.pem`` files > should now be securely copied to the client for which they were > @@ -222,7 +218,6 @@ client and server instructions in one. > ip_address = 2001:24::92 > tls_www_server > tls_www_client > - encryption_key > signing_key > EOF > # certtool --generate-privkey > both-hostNNN-key.pem > diff --git a/tests/unit/crypto-tls-x509-helpers.h b/tests/unit/crypto-tls-x509-helpers.h > index 2a0f7c04fd..7e9a508ad6 100644 > --- a/tests/unit/crypto-tls-x509-helpers.h > +++ b/tests/unit/crypto-tls-x509-helpers.h > @@ -148,8 +148,7 @@ void test_tls_cleanup(const char *keyfile); > .basicConstraintsIsCA = false, \ > .keyUsageEnable = true, \ > .keyUsageCritical = true, \ > - .keyUsageValue = \ > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, \ > + .keyUsageValue = GNUTLS_KEY_DIGITAL_SIGNATURE, \ > .keyPurposeEnable = true, \ > .keyPurposeCritical = true, \ > .keyPurposeOID1 = GNUTLS_KP_TLS_WWW_CLIENT, \ > @@ -168,8 +167,7 @@ void test_tls_cleanup(const char *keyfile); > .basicConstraintsIsCA = false, \ > .keyUsageEnable = true, \ > .keyUsageCritical = true, \ > - .keyUsageValue = \ > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, \ > + .keyUsageValue = GNUTLS_KEY_DIGITAL_SIGNATURE, \ > .keyPurposeEnable = true, \ > .keyPurposeCritical = true, \ > .keyPurposeOID1 = GNUTLS_KP_TLS_WWW_SERVER, \ > diff --git a/tests/unit/test-crypto-tlscredsx509.c b/tests/unit/test-crypto-tlscredsx509.c > index 96ad4e741b..a5f21728d4 100644 > --- a/tests/unit/test-crypto-tlscredsx509.c > +++ b/tests/unit/test-crypto-tlscredsx509.c > @@ -169,14 +169,14 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > TLS_CERT_REQ(clientcertreq, cacertreq, > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 0, 0); > > @@ -199,7 +199,7 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > > @@ -214,7 +214,7 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > > @@ -229,7 +229,7 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > > @@ -253,7 +253,7 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > /* no-basic */ > @@ -267,7 +267,7 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > /* Key usage:dig-sig:critical */ > @@ -281,7 +281,7 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > > @@ -306,7 +306,7 @@ int main(int argc, char **argv) > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT | > + GNUTLS_KEY_DIGITAL_SIGNATURE | > GNUTLS_KEY_KEY_CERT_SIGN, > false, false, NULL, NULL, > 0, 0); > @@ -409,7 +409,7 @@ int main(int argc, char **argv) > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT | > + GNUTLS_KEY_DIGITAL_SIGNATURE | > GNUTLS_KEY_KEY_CERT_SIGN, > false, false, NULL, NULL, > 0, 0); > @@ -511,21 +511,21 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > TLS_CERT_REQ(servercertexp1req, cacertreq, > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, -1); > TLS_CERT_REQ(clientcertexp1req, cacertreq, > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 0, -1); > > @@ -549,21 +549,21 @@ int main(int argc, char **argv) > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > TLS_CERT_REQ(servercertnew1req, cacertreq, > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 1, 2); > TLS_CERT_REQ(clientcertnew1req, cacertreq, > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 1, 2); > > @@ -614,14 +614,14 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > TLS_CERT_REQ(clientcertlevel2breq, cacertlevel1breq, > "UK", "qemu client level 2b", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 0, 0); > > diff --git a/tests/unit/test-crypto-tlssession.c b/tests/unit/test-crypto-tlssession.c > index 61311cbe6e..d0baf3b304 100644 > --- a/tests/unit/test-crypto-tlssession.c > +++ b/tests/unit/test-crypto-tlssession.c > @@ -472,14 +472,14 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > TLS_CERT_REQ(clientcertreq, cacertreq, > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 0, 0); > > @@ -487,7 +487,7 @@ int main(int argc, char **argv) > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 0, 0); > > @@ -506,7 +506,7 @@ int main(int argc, char **argv) > "192.168.122.1", "fec0::dead:beaf", > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > /* This intentionally doesn't replicate */ > @@ -515,7 +515,7 @@ int main(int argc, char **argv) > "192.168.122.1", "fec0::dead:beaf", > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > > @@ -619,14 +619,14 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > TLS_CERT_REQ(clientcertlevel2breq, cacertlevel1breq, > "UK", "qemu client level 2b", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 0, 0); > > diff --git a/tests/unit/test-io-channel-tls.c b/tests/unit/test-io-channel-tls.c > index 6f282ad45d..4e4034af67 100644 > --- a/tests/unit/test-io-channel-tls.c > +++ b/tests/unit/test-io-channel-tls.c > @@ -302,14 +302,14 @@ int main(int argc, char **argv) > "UK", "qemu.org", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_SERVER, NULL, > 0, 0); > TLS_CERT_REQ(clientcertreq, cacertreq, > "UK", "qemu", NULL, NULL, NULL, NULL, > true, true, false, > true, true, > - GNUTLS_KEY_DIGITAL_SIGNATURE | GNUTLS_KEY_KEY_ENCIPHERMENT, > + GNUTLS_KEY_DIGITAL_SIGNATURE, > true, true, GNUTLS_KP_TLS_WWW_CLIENT, NULL, > 0, 0); > > -- > 2.50.1 > With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|