qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Bin Meng" <bmeng.cn@gmail.com>,
	qemu-block@nongnu.org,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Jan Lübbe" <jlu@pengutronix.de>,
	"Jerome Forissier" <jerome.forissier@linaro.org>
Subject: Re: [PATCH v5 2/6] hw/sd/sdcard: Allow user-instantiated eMMC
Date: Mon, 27 Oct 2025 11:55:40 +0000	[thread overview]
Message-ID: <aP9dvF1unTtLrSdQ@redhat.com> (raw)
In-Reply-To: <90fc6201696fcf0e5fd0493365bc32b217aa9d6e.1760702638.git.jan.kiszka@siemens.com>

On Fri, Oct 17, 2025 at 02:03:54PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Enable user-instantiation so that PCI-attached eMMCs can be created for
> virt machines, for QA purposes for the eMMC model itself and for complex
> firmware/OS integrations using the upcoming RPMB partition support.

IIUC, the 'emmc' device wants an 'sd-bus' but this commit talks about
it being PCI-attached ?

Can you elaborate on / illustrate the usage example for an end user ?

> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/sd/sd.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index d1e1bb4f0e..305ea251cb 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2928,8 +2928,6 @@ static void emmc_class_init(ObjectClass *klass, const void *data)
>      dc->desc = "eMMC";
>      dc->realize = emmc_realize;
>      device_class_set_props(dc, emmc_properties);
> -    /* Reason: Soldered on board */
> -    dc->user_creatable = false;
>  
>      sc->proto = &sd_proto_emmc;
>  
> -- 
> 2.51.0
> 
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2025-10-27 11:57 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-17 12:03 [PATCH v5 0/6] sd: Add RPMB emulation to eMMC model Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 1/6] hw/sd/sdcard: Fix size check for backing block image Jan Kiszka
2025-10-20  7:29   ` Cédric Le Goater
2025-10-30 22:10   ` Philippe Mathieu-Daudé
2025-10-17 12:03 ` [PATCH v5 2/6] hw/sd/sdcard: Allow user-instantiated eMMC Jan Kiszka
2025-10-27 11:55   ` Daniel P. Berrangé [this message]
2025-10-27 12:23     ` Philippe Mathieu-Daudé
2025-10-27 12:35       ` Daniel P. Berrangé
2025-10-27 12:44         ` Philippe Mathieu-Daudé
2025-10-30 14:17           ` Jan Lübbe
2025-10-27 12:45       ` Jan Lübbe
2025-10-30 16:50   ` Jan Lübbe
2025-10-30 18:10     ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 3/6] hw/sd/sdcard: Add basic support for RPMB partition Jan Kiszka
2025-11-03 15:08   ` Philippe Mathieu-Daudé
2025-11-04  6:34     ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 4/6] hw/sd/sdcard: Handle RPMB MAC field Jan Kiszka
2025-11-03 15:18   ` Philippe Mathieu-Daudé
2025-11-04  6:43     ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 5/6] scripts: Add helper script to generate eMMC block device images Jan Kiszka
2025-11-03 13:12   ` Philippe Mathieu-Daudé
2025-11-04  6:30     ` Jan Kiszka
2025-11-04  9:26       ` Jan Kiszka
2025-11-04 12:33         ` Philippe Mathieu-Daudé
2025-11-04 12:40           ` Jan Kiszka
2025-11-04 14:14             ` Jan Kiszka
2025-10-17 12:03 ` [PATCH v5 6/6] docs: Add eMMC device model description Jan Kiszka
2025-11-03 13:15   ` Philippe Mathieu-Daudé
2025-10-20  7:28 ` [PATCH v5 0/6] sd: Add RPMB emulation to eMMC model Cédric Le Goater
2025-10-27 11:15 ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aP9dvF1unTtLrSdQ@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bmeng.cn@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=jan.kiszka@siemens.com \
    --cc=jerome.forissier@linaro.org \
    --cc=jlu@pengutronix.de \
    --cc=philmd@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).