* [PATCH] meson: do not descend into *-user if no user-mode emulators built
@ 2025-10-16 17:03 Paolo Bonzini
2025-10-16 17:17 ` Daniel P. Berrangé
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2025-10-16 17:03 UTC (permalink / raw)
To: qemu-devel
User-mode emulators cannot be built for unsupported host architectures;
avoid incorrectly descending into common-user/unknown.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
meson.build | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/meson.build b/meson.build
index afaefa01722..3facde5b68f 100644
--- a/meson.build
+++ b/meson.build
@@ -3935,9 +3935,11 @@ endif
common_user_inc = []
-subdir('common-user')
-subdir('bsd-user')
-subdir('linux-user')
+if have_user
+ subdir('common-user')
+ subdir('bsd-user')
+ subdir('linux-user')
+endif
# needed for fuzzing binaries
subdir('tests/qtest/libqos')
--
2.51.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] meson: do not descend into *-user if no user-mode emulators built
2025-10-16 17:03 [PATCH] meson: do not descend into *-user if no user-mode emulators built Paolo Bonzini
@ 2025-10-16 17:17 ` Daniel P. Berrangé
0 siblings, 0 replies; 2+ messages in thread
From: Daniel P. Berrangé @ 2025-10-16 17:17 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
On Thu, Oct 16, 2025 at 07:03:57PM +0200, Paolo Bonzini wrote:
> User-mode emulators cannot be built for unsupported host architectures;
> avoid incorrectly descending into common-user/unknown.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> meson.build | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index afaefa01722..3facde5b68f 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -3935,9 +3935,11 @@ endif
>
> common_user_inc = []
>
> -subdir('common-user')
> -subdir('bsd-user')
> -subdir('linux-user')
> +if have_user
> + subdir('common-user')
> + subdir('bsd-user')
> + subdir('linux-user')
> +endif
The first lines of meson.buld in each subdir are already doing a
check and calling subdir_done() straighaway, so what does this
really give us ?
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-10-16 17:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-16 17:03 [PATCH] meson: do not descend into *-user if no user-mode emulators built Paolo Bonzini
2025-10-16 17:17 ` Daniel P. Berrangé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).