From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F66BCCD1A7 for ; Tue, 21 Oct 2025 13:55:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBCpc-0007pX-HP; Tue, 21 Oct 2025 09:55:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBCpZ-0007pE-W5 for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:55:18 -0400 Received: from mail.xenproject.org ([104.130.215.37]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBCpV-0007h3-1J for qemu-devel@nongnu.org; Tue, 21 Oct 2025 09:55:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=xenproject.org; s=20200302mail; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=soAqTR95YKtmT/yWQ+zKpozInVkIEeOQhkWi/RjtcA0=; b=g/y2XQFpxz1k0HpbR3+1JHwlWa xl1cHz6qOAZR2nxQYlSXho4bM4ROdfRgg5Jfslhxmh0K/St4qVTmzeex1NVYp0RB4btFtKPKGSGRj ihqItw8GcRKxXfvSpgOTtjzYrnOEo79q4UIvG7NSZTWcUXtds5pbM8j1xj5POATtrMDQ=; Received: from xenbits.xenproject.org ([104.239.192.120]) by mail.xenproject.org with esmtp (Exim 4.96) (envelope-from ) id 1vBCpP-00CjuQ-0f; Tue, 21 Oct 2025 13:55:07 +0000 Received: from [2a01:e0a:1da:8420:b77:bd5:6e45:7633] (helo=l14) by xenbits.xenproject.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1vBCpP-005stU-0I; Tue, 21 Oct 2025 13:55:07 +0000 Date: Tue, 21 Oct 2025 15:55:05 +0200 From: Anthony PERARD To: Roger Pau Monne Cc: qemu-devel@nongnu.org, Stefano Stabellini , Paul Durrant , "Edgar E. Iglesias" , xen-devel@lists.xenproject.org Subject: Re: [PATCH] hw/xen: pass PCI domain to xc_physdev_map_pirq_msi() Message-ID: References: <20251017155136.16540-1-roger.pau@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251017155136.16540-1-roger.pau@citrix.com> Received-SPF: pass client-ip=104.130.215.37; envelope-from=anthony@xenproject.org; helo=mail.xenproject.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 17, 2025 at 05:51:36PM +0200, Roger Pau Monne wrote: > It's currently impossible for passthrough devices on segment different than > 0 to work correctly, as the PCI domain is not provided to > xc_physdev_map_pirq_msi(), and hence it's unconditionally assumed that all > devices are on segment 0. > > Adjust the call to xc_physdev_map_pirq_msi() to pass the PCI domain in the > high 16bits of the bus parameter. On versions of Xen where this is not > supported the passed segment will be ignored and assume to be 0, no worse > than the current state. > > Signed-off-by: Roger Pau Monné Reviewed-by: Anthony PERARD Thanks, -- Anthony PERARD