qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Kevin Wolf <kwolf@redhat.com>, Hanna Reitz <hreitz@redhat.com>
Subject: Re: [PATCH] iotests: Adjust fuse-allow-other expected output
Date: Wed, 22 Oct 2025 09:36:12 +0100	[thread overview]
Message-ID: <aPiXfHT9BCX8vwLo@redhat.com> (raw)
In-Reply-To: <20251021205843.2585624-2-eblake@redhat.com>

On Tue, Oct 21, 2025 at 03:58:40PM -0500, Eric Blake wrote:
> The iotest fuse-allow-other has been broken since commit effd60c8 in
> v9.0.0; but as Dan Berrange's efforts to improve CI have proven, we
> haven't been reliably running it to notice.  The change in that commit
> was good (moving coroutine commands to run in the right context), but
> it meant that "execute":"quit" now waits to complete until the
> coroutines tearing down fuse have first reported the SHUTDOWN event,
> in the opposite order of what happened pre-patch.
> 
> Signed-off-by: Eric Blake <eblake@redhat.com>
> Fixes: effd60c8 ("monitor: only run coroutine commands in qemu_aio_context",
> Reported-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  tests/qemu-iotests/tests/fuse-allow-other.out | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2025-10-22  8:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 20:58 [PATCH] iotests: Adjust fuse-allow-other expected output Eric Blake
2025-10-22  8:36 ` Daniel P. Berrangé [this message]
2025-10-23 17:50 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aPiXfHT9BCX8vwLo@redhat.com \
    --to=berrange@redhat.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).