From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABDF8CCD195 for ; Wed, 22 Oct 2025 09:03:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBUk3-0007nl-KQ; Wed, 22 Oct 2025 05:02:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBUk2-0007nW-Da for qemu-devel@nongnu.org; Wed, 22 Oct 2025 05:02:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBUjz-0000Rr-E0 for qemu-devel@nongnu.org; Wed, 22 Oct 2025 05:02:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761123760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UveFgYBY+4qkyC/TL86MbPgqVbXabMu1c33IJukz0fI=; b=KA5oKPJyuf+K36W5j8akiKXh4ouCbp4NhpcSGX4bwB+SZpApeFxjyi8RnEmMgKnBSV3FBI EokQrSZ2spbXz7Vh7PN4MG6EzhXHVS+Wp5swIASMl5lbBlTHLLaknxDyK93fhRgoS9gcPU u/2RRT6sZXr/iy3+S3LPyUc0FdalTT8= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-157-tVTKI-TcNlGSkuNnxsXN7A-1; Wed, 22 Oct 2025 05:02:36 -0400 X-MC-Unique: tVTKI-TcNlGSkuNnxsXN7A-1 X-Mimecast-MFC-AGG-ID: tVTKI-TcNlGSkuNnxsXN7A_1761123755 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A8C1A19560AD; Wed, 22 Oct 2025 09:02:34 +0000 (UTC) Received: from redhat.com (unknown [10.45.225.168]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3FDD9180057C; Wed, 22 Oct 2025 09:02:30 +0000 (UTC) Date: Wed, 22 Oct 2025 11:02:28 +0200 From: Kevin Wolf To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Aarushi Mehta , Fam Zheng , Stefano Garzarella , Hanna Czenczek , eblake@redhat.com, qemu-block@nongnu.org, hibriansong@gmail.com, Stefan Weil , Paolo Bonzini Subject: Re: [PATCH v4 05/12] aio: remove aio_context_use_g_source() Message-ID: References: <20250910175703.374499-1-stefanha@redhat.com> <20250910175703.374499-6-stefanha@redhat.com> <20251021191033.GB4837@fedora> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7BVxhzHfjb3wzXk/" Content-Disposition: inline In-Reply-To: <20251021191033.GB4837@fedora> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --7BVxhzHfjb3wzXk/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 21.10.2025 um 21:10 hat Stefan Hajnoczi geschrieben: > On Thu, Oct 09, 2025 at 06:59:20PM +0200, Kevin Wolf wrote: > > Am 09.10.2025 um 17:46 hat Kevin Wolf geschrieben: > > > Am 10.09.2025 um 19:56 hat Stefan Hajnoczi geschrieben: > > > > There is no need for aio_context_use_g_source() now that epoll(7) a= nd > > > > io_uring(7) file descriptor monitoring works with the glib event lo= op. > > > > AioContext doesn't need to be notified that GSource is being used. > > > >=20 > > > > Signed-off-by: Stefan Hajnoczi > > > > Reviewed-by: Eric Blake > > >=20 > > > We should probably mention in the commit message that this causes the > > > default fdmon on Linux to change from poll to io_uring. It's a small > > > code change, but it makes QEMU use a completely different code path by > > > default. > >=20 > > Just to make sure, I ran 'make check' after this patch and it's failing > > for me: > >=20 > > 10/401 qemu:qtest+qtest-x86_64 / qtest-x86_64/ahci-test = TIMEOUT 150.02s killed by signal 15 SIGTERM > > 133/401 qemu:unit / test-aio = TIMEOUT 30.01s killed by signal 15 SIGTERM > > 137/401 qemu:unit / test-bdrv-drain = TIMEOUT 30.01s killed by signal 15 SIGTERM > > 142/401 qemu:unit / test-block-iothread = TIMEOUT 30.01s killed by signal 15 SIGTERM > > 192/401 qemu:doc+rust / rust-bql-rs-doctests = FAIL 0.84s exit status 101 > > 311/401 qemu:block / io-qcow2-267 = ERROR 3.20s exit status 1 > > 321/401 qemu:block / io-qcow2-copy-before-write = TIMEOUT 180.01s killed by signal 15 SIGTERM > >=20 > > Some of them look unrelated, but I have confirmed that the three unit > > tests still pass before this patch (and still hang after the complete > > series). >=20 > I can't reproduce these failures, regardless of whether sysctl > kernel.io_uring_disabled is 0 or 1. >=20 > Can you launch the unit tests from your terminal and post the output? >=20 > $ cd qemu > $ build/tests/unit/test-aio TAP version 14 # random seed: R02S48dcdde28634143f18bad3947c52d334 1..27 # Start of aio tests # Start of bh tests ok 1 /aio/bh/schedule ok 2 /aio/bh/schedule10 ok 3 /aio/bh/cancel ok 4 /aio/bh/delete ok 5 /aio/bh/flush # Start of callback-delete tests ok 6 /aio/bh/callback-delete/one ok 7 /aio/bh/callback-delete/many # End of callback-delete tests # End of bh tests # Start of event tests ok 8 /aio/event/add-remove ok 9 /aio/event/wait ok 10 /aio/event/flush # Start of wait tests ok 11 /aio/event/wait/no-flush-cb # End of wait tests # End of event tests # Start of timer tests > $ build/tests/unit/test-bdrv-drain TAP version 14 # random seed: R02S7d6ba0fc81d5b90d323813d680a30644 1..30 # Start of bdrv-drain tests ok 1 /bdrv-drain/nested ok 2 /bdrv-drain/set_aio_context # Start of driver-cb tests > $ build/tests/unit/test-block-iothread TAP version 14 # random seed: R02Sf81baf68887daa9b86be5c72b99df589 1..22 # Start of sync-op tests ok 1 /sync-op/pread ok 2 /sync-op/pwrite ok 3 /sync-op/preadv ok 4 /sync-op/pwritev ok 5 /sync-op/preadv_part ok 6 /sync-op/pwritev_part ok 7 /sync-op/pwrite_compressed ok 8 /sync-op/pwrite_zeroes ok 9 /sync-op/load_vmstate ok 10 /sync-op/save_vmstate ok 11 /sync-op/pdiscard ok 12 /sync-op/truncate ok 13 /sync-op/block_status ok 14 /sync-op/flush ok 15 /sync-op/check ok 16 /sync-op/activate # End of sync-op tests # Start of attach tests > That will show exactly which sub-test case is hanging. > Other information that might help: your host kernel version and liburing > version. This is a F42 system. kernel-6.16.12-200.fc42.x86_64 liburing-2.9-1.fc42.x86_64 If you can't reproduce or find a hypothesis what's happening, I can try to debug one of the hanging processes. Kevin --7BVxhzHfjb3wzXk/ Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmj4naQACgkQfwmycsiP L9bS8BAAkeCQUXN+5vTBb2jCde+wlNo/td2IvsrXzwmPwDlfHwZOkEQgick73ucg G3V1D+LypjeqPrTbNkcq+HBr5Qhp48GJVC1iIAUoUQX5jOjyARwRXFI2VJNsdB8D B06gayBDvtj9a5zbsqJgHay3eDFzLljjEqG6dOWeQJPuBAw2i2S8s72Xh5+IhYbl 7eGkIROJLREF9ilQ+u8Kf4/x6EQA3cyawVqaD1Lx3oVB15MlYpITrk4FZtGHi0St hsrxlvKbK7Y9Ws3WjnYnndpk2e9J/ao8dlFudWYbX1E2TCS1UFiQ/UEciZwUao7W V573fYpUisb/QMDFZwFA3/xUPbbVcp9a9EafiwUnBNkDI5kNKrtJX6Xe63D4KAHO fhjNqcWS4vemG8F4EP2UbJnI9IRr31Dfo0kH27ooAXfEqFVm9k5AluDcttin4O5t 9+QakGw8X3GdgMuO/Q6Eez2yEvvsqhiDdqIXn0j+c8ADcmyFkyNMKbC4EQarHGjo 7+wOq8g4k5+5Clt7sY3CsJcerdkZRAiQFB4ZK9cGVuzuCU2BrCAyt19Dbg4xdrpL l9Ad/jbmrPLs4EKTZzBcAct6KFSZCL4zBVVCDXt8evDb14BRYy/IrmKawkxuy3Mo ppj8MsEfRkIRPmuAAcdLjiOeFfLZDRqm7gRhkCgE5qTpfNJphr8= =04+n -----END PGP SIGNATURE----- --7BVxhzHfjb3wzXk/--