From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5B9BCCD1BE for ; Thu, 23 Oct 2025 15:16:14 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vBx2d-0002Bo-FX; Thu, 23 Oct 2025 11:15:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBx2Y-0002Au-Fz for qemu-devel@nongnu.org; Thu, 23 Oct 2025 11:15:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vBx2W-00087W-Sz for qemu-devel@nongnu.org; Thu, 23 Oct 2025 11:15:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761232544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1Dae3X4cXISlzBiRGUoW74FbrFF3rxVfziGcHGhkaMA=; b=R7D2LvYmX6q4hV22XIoEUKPeNtGae+8VZNeh0a+V6Yf620QbrYpiVmoqgKAtx5SmBcZICz sXM+xn0kmDrSxatgrNZhp2UWiFOECYut+wzccK3bwUS4RiVTa2r3Z16nCI+IniEHM0OlzC vXm32zqEFx56WYXL+Y4O56bW5DZBn0E= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-QdDfPrYcMqOiwKZxBL4sRg-1; Thu, 23 Oct 2025 11:15:40 -0400 X-MC-Unique: QdDfPrYcMqOiwKZxBL4sRg-1 X-Mimecast-MFC-AGG-ID: QdDfPrYcMqOiwKZxBL4sRg_1761232539 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8CC501802B4F; Thu, 23 Oct 2025 15:15:39 +0000 (UTC) Received: from redhat.com (unknown [10.45.225.90]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ED02118004D4; Thu, 23 Oct 2025 15:15:36 +0000 (UTC) Date: Thu, 23 Oct 2025 17:15:34 +0200 From: Kevin Wolf To: Hanna Czenczek Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Stefan Hajnoczi , Markus Armbruster , Brian Song Subject: Re: [PATCH v3 00/21] export/fuse: Use coroutines and multi-threading Message-ID: References: <20250701114437.207419-1-hreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250701114437.207419-1-hreitz@redhat.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 01.07.2025 um 13:44 hat Hanna Czenczek geschrieben: > Hi, > > This series: > - Fixes some bugs/minor inconveniences, > - Removes libfuse from the request processing path, > - Make the FUSE export use coroutines for request handling, > - Introduces multi-threading into the FUSE export. > > More detail on the v1 cover letter: > https://lists.nongnu.org/archive/html/qemu-block/2025-03/msg00359.html > > v2 cover letter: > https://lists.nongnu.org/archive/html/qemu-block/2025-06/msg00040.html I have finished review and while I did have comments here and there how things could be nicer, I don't think I saw a real blocker. Please have a look at my comments and let me know if you intend to respin the series or if there are things I should fix up while applying the patches. Kevin