From: Kevin Wolf <kwolf@redhat.com>
To: Chandan Somani <csomani@redhat.com>
Cc: qemu-devel@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
John Snow <jsnow@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: Re: [PATCH v2] block: enable stats-intervals for storage devices
Date: Thu, 23 Oct 2025 20:05:47 +0200 [thread overview]
Message-ID: <aPpue5a-uCkdlc9z@redhat.com> (raw)
In-Reply-To: <20251003220039.1336663-1-csomani@redhat.com>
Am 03.10.2025 um 23:59 hat Chandan Somani geschrieben:
> This patch allows stats-intervals to be used for storage
> devices with the -device option. It accepts a list of interval
> lengths in JSON format.
>
> It configures and collects the stats in the BlockBackend layer
> through the storage device that consumes the BlockBackend.
>
> Signed-off-by: Chandan Somani <csomani@redhat.com>
Thanks, applied to the block branch.
Maybe you can add a patch on top that extends tests/qemu-iotests/136 to
also test the -device based settings (probably in a new child class)
instead of only -drive?
Kevin
next prev parent reply other threads:[~2025-10-23 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 21:59 [PATCH v2] block: enable stats-intervals for storage devices Chandan Somani
2025-10-23 18:05 ` Kevin Wolf [this message]
2025-10-27 20:08 ` Chandan Somani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aPpue5a-uCkdlc9z@redhat.com \
--to=kwolf@redhat.com \
--cc=csomani@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).