From: Zhao Liu <zhao1.liu@intel.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
David Hildenbrand <david@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/functional/x86_64/test_virtio_balloon: Fix cosmetic issues from pylint
Date: Wed, 29 Oct 2025 23:42:55 +0800 [thread overview]
Message-ID: <aQI1/0uNyczHcLsT@intel.com> (raw)
In-Reply-To: <20251029075342.47335-1-thuth@redhat.com>
On Wed, Oct 29, 2025 at 08:53:42AM +0100, Thomas Huth wrote:
> Date: Wed, 29 Oct 2025 08:53:42 +0100
> From: Thomas Huth <thuth@redhat.com>
> Subject: [PATCH] tests/functional/x86_64/test_virtio_balloon: Fix cosmetic
> issues from pylint
>
> From: Thomas Huth <thuth@redhat.com>
>
> Pylint complains about some style issues in this file: Unused variables
> should be marked with an underscore, "when > then and when < now"
> can be simplified to "now > when > then" and expectData doesn't conform
> to the usual snake_case naming style.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/functional/x86_64/test_virtio_balloon.py | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
LGTM,
Reviewed-by: Zhao Liu <zhao1.liu@intel.com>
prev parent reply other threads:[~2025-10-29 15:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 7:53 [PATCH] tests/functional/x86_64/test_virtio_balloon: Fix cosmetic issues from pylint Thomas Huth
2025-10-29 7:59 ` Manos Pitsidianakis
2025-10-29 15:42 ` Zhao Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQI1/0uNyczHcLsT@intel.com \
--to=zhao1.liu@intel.com \
--cc=david@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).