Re: [PATCH 12/21] crypto: introduce method for reloading TLS creds

["Daniel P. Berrangé" <berrange@redhat.com>]

On Thu, Oct 30, 2025 at 11:43:29PM +0400, Marc-André Lureau wrote:
> On Thu, Oct 30, 2025 at 6:49 PM Daniel P. Berrangé <berrange@redhat.com>
> wrote:
> 
> > This prevents direct access of the class members by the VNC
> > display code.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> >
> 
> Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> 
> > ---
> >  crypto/tlscreds.c         | 15 +++++++++++++++
> >  include/crypto/tlscreds.h | 13 +++++++++++++
> >  ui/vnc.c                  |  9 +--------
> >  3 files changed, 29 insertions(+), 8 deletions(-)
> >
> > diff --git a/crypto/tlscreds.c b/crypto/tlscreds.c
> > index 49c7eb46a5..9433b4c363 100644
> > --- a/crypto/tlscreds.c
> > +++ b/crypto/tlscreds.c
> > @@ -281,6 +281,21 @@ char *qcrypto_tls_creds_get_priority(QCryptoTLSCreds
> > *creds)
> >  }
> >
> >
> > +bool qcrypto_tls_creds_reload(QCryptoTLSCreds *creds,
> > +                              Error **errp)
> > +{
> > +    QCryptoTLSCredsClass *credscls =
> > QCRYPTO_TLS_CREDS_GET_CLASS(OBJECT(creds));
> > +
> >
> 
> OBJECT() unnecessary here

Ah yes, will remove it.


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|