From: Peter Xu <peterx@redhat.com>
To: Juraj Marcin <jmarcin@redhat.com>
Cc: qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dave@treblig.org>,
Fabiano Rosas <farosas@suse.de>,
Jiri Denemark <jdenemar@redhat.com>
Subject: Re: [PATCH v4 1/8] migration: Flush migration channel after sending data of CMD_PACKAGED
Date: Mon, 3 Nov 2025 14:04:15 -0500 [thread overview]
Message-ID: <aQj8r_irRaZU2sQm@x1.local> (raw)
In-Reply-To: <20251103183301.3840862-2-jmarcin@redhat.com>
On Mon, Nov 03, 2025 at 07:32:50PM +0100, Juraj Marcin wrote:
> From: Juraj Marcin <jmarcin@redhat.com>
>
> If the length of the data sent after CMD_PACKAGED is just right, and
> there is not much data to send afterward, it is possible part of the
> CMD_PACKAGED payload will get left behind in the sending buffer. This
> causes the destination side to hang while it tries to load the whole
> package and initiate postcopy.
>
> Signed-off-by: Juraj Marcin <jmarcin@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2025-11-03 19:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 18:32 [PATCH v4 0/8] migration: Introduce POSTCOPY_DEVICE state Juraj Marcin
2025-11-03 18:32 ` [PATCH v4 1/8] migration: Flush migration channel after sending data of CMD_PACKAGED Juraj Marcin
2025-11-03 19:04 ` Peter Xu [this message]
2025-11-03 18:32 ` [PATCH v4 2/8] migration: Do not try to start VM if disk activation fails Juraj Marcin
2025-11-03 18:32 ` [PATCH v4 3/8] migration: Move postcopy_ram_listen_thread() to postcopy-ram.c Juraj Marcin
2025-11-03 18:32 ` [PATCH v4 4/8] migration: Introduce postcopy incoming setup and cleanup functions Juraj Marcin
2025-11-03 18:32 ` [PATCH v4 5/8] migration: Refactor all incoming cleanup info migration_incoming_destroy() Juraj Marcin
2025-11-03 18:32 ` [PATCH v4 6/8] migration: Respect exit-on-error when migration fails before resuming Juraj Marcin
2025-11-03 18:32 ` [PATCH v4 7/8] migration: Make postcopy listen thread joinable Juraj Marcin
2025-11-03 18:32 ` [PATCH v4 8/8] migration: Introduce POSTCOPY_DEVICE state Juraj Marcin
2025-11-03 19:09 ` Peter Xu
2025-11-03 21:07 ` [PATCH v4 0/8] " Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQj8r_irRaZU2sQm@x1.local \
--to=peterx@redhat.com \
--cc=dave@treblig.org \
--cc=farosas@suse.de \
--cc=jdenemar@redhat.com \
--cc=jmarcin@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).