qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: BALATON Zoltan <balaton@eik.bme.hu>, qemu-devel@nongnu.org
Subject: Re: [PATCH v5] hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field
Date: Mon, 3 Nov 2025 23:10:28 +0800	[thread overview]
Message-ID: <aQjF5PdR0s/WrA3+@intel.com> (raw)
In-Reply-To: <20251103104231.05121741@fedora>

On Mon, Nov 03, 2025 at 10:42:31AM +0100, Igor Mammedov wrote:
> Date: Mon, 3 Nov 2025 10:42:31 +0100
> From: Igor Mammedov <imammedo@redhat.com>
> Subject: Re: [PATCH v5] hw/i386/pc: Remove
>  PCMachineClass::legacy_cpu_hotplug field
> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu)
> 
> On Sat, 1 Nov 2025 00:27:36 +0100 (CET)
> BALATON Zoltan <balaton@eik.bme.hu> wrote:
> 
> [...]
> > > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > > index dfb8523c8b..7191854857 100644
> > > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > > @@ -1 +1,43 @@  
> > 
> > Does this belong here?
> thanks for spotting it, it should be a separate preceding patch,

Thanks! I think I see :-) - I should follow the gudience in
tests/qtest/bios-tables-test.c, to split this patch.

> and then expected blobs update patch after this patch,
> that would cleanup bios-tables-test-allowed-diff.h along with new blobs.
> /i.e. as per process described in bios-tables-test.c /

Regards,
Zhao



  reply	other threads:[~2025-11-03 14:49 UTC|newest]

Thread overview: 118+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-08 13:35 [PATCH v4 00/27] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines Philippe Mathieu-Daudé
2025-05-08 13:35 ` [PATCH v4 01/27] hw/i386/pc: Remove deprecated pc-q35-2.6 and pc-i440fx-2.6 machines Philippe Mathieu-Daudé
2025-05-09 15:23   ` Igor Mammedov
2025-06-02  6:13     ` Thomas Huth
2025-06-02  8:53       ` Philippe Mathieu-Daudé
2025-06-02 10:26         ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 02/27] hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field Philippe Mathieu-Daudé
2025-05-09 15:18   ` Igor Mammedov
2025-10-31 14:28   ` [PATCH v5] " Igor Mammedov
2025-10-31 23:27     ` BALATON Zoltan
2025-11-03  9:42       ` Igor Mammedov
2025-11-03 15:10         ` Zhao Liu [this message]
2025-05-08 13:35 ` [PATCH v4 03/27] hw/nvram/fw_cfg: Rename fw_cfg_init_mem() with '_nodma' suffix Philippe Mathieu-Daudé
2025-05-09  2:49   ` Zhao Liu
2025-05-09 15:33   ` Igor Mammedov
2025-05-15  8:04   ` Xiaoyao Li
2025-05-08 13:35 ` [PATCH v4 04/27] hw/mips/loongson3_virt: Prefer using fw_cfg_init_mem_nodma() Philippe Mathieu-Daudé
2025-05-09  2:49   ` Zhao Liu
2025-05-09 15:35   ` Igor Mammedov
2025-05-15  8:05   ` Xiaoyao Li
2025-05-08 13:35 ` [PATCH v4 05/27] hw/nvram/fw_cfg: Factor fw_cfg_init_mem_internal() out Philippe Mathieu-Daudé
2025-05-09  2:50   ` Zhao Liu
2025-05-09 15:38   ` Igor Mammedov
2025-05-15  8:08   ` Xiaoyao Li
2025-05-08 13:35 ` [PATCH v4 06/27] hw/nvram/fw_cfg: Rename fw_cfg_init_mem_wide() -> fw_cfg_init_mem_dma() Philippe Mathieu-Daudé
2025-05-09  2:52   ` Zhao Liu
2025-05-09  6:51   ` Zhao Liu
2025-05-09 15:39     ` Igor Mammedov
2025-05-15  8:17   ` Xiaoyao Li
2025-05-08 13:35 ` [PATCH v4 07/27] hw/i386/x86: Remove X86MachineClass::fwcfg_dma_enabled field Philippe Mathieu-Daudé
2025-05-09  3:23   ` Zhao Liu
2025-05-09 15:41   ` Igor Mammedov
2025-05-09 15:44     ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 08/27] hw/i386/pc: Remove multiboot.bin Philippe Mathieu-Daudé
2025-05-09  6:11   ` Zhao Liu
2025-05-08 13:35 ` [PATCH v4 09/27] hw/nvram/fw_cfg: Remove fw_cfg_io_properties::dma_enabled Philippe Mathieu-Daudé
2025-05-09  6:37   ` Zhao Liu
2025-05-09 16:00   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 10/27] hw/i386/pc: Remove linuxboot.bin Philippe Mathieu-Daudé
2025-05-09  6:53   ` Zhao Liu
2025-05-09 16:04   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 11/27] hw/i386/pc: Remove pc_compat_2_6[] array Philippe Mathieu-Daudé
2025-05-09  6:54   ` Zhao Liu
2025-05-12  8:19   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 12/27] target/i386/cpu: Remove CPUX86State::enable_cpuid_0xb field Philippe Mathieu-Daudé
2025-05-09  6:49   ` Xiaoyao Li
2025-05-09  7:32     ` Zhao Liu
2025-05-09 10:04       ` How to mark internal properties (was: Re: [PATCH v4 12/27] target/i386/cpu: Remove CPUX86State::enable_cpuid_0xb field) Thomas Huth
2025-05-12  2:45         ` Zhao Liu
2025-05-12  6:34         ` How to mark internal properties Markus Armbruster
2025-05-12  8:46         ` How to mark internal properties (was: Re: [PATCH v4 12/27] target/i386/cpu: Remove CPUX86State::enable_cpuid_0xb field) Peter Maydell
2025-05-12  9:06           ` Daniel P. Berrangé
2025-05-12 10:54             ` How to mark internal properties Markus Armbruster
2025-05-12 13:33               ` Xiaoyao Li
2025-05-12 14:41                 ` BALATON Zoltan
2025-05-13  8:16                   ` Thomas Huth
2025-05-12 14:48               ` Mark Cave-Ayland
2025-05-13  8:18                 ` Markus Armbruster
2025-05-13  9:26                   ` BALATON Zoltan
2025-05-13  9:32                     ` Daniel P. Berrangé
2025-05-13 10:38                       ` Markus Armbruster
2025-05-13 11:01                     ` Markus Armbruster
2025-05-26  8:58                     ` Markus Armbruster
2025-05-12 15:22               ` Igor Mammedov
2025-05-13  8:08                 ` Markus Armbruster
2025-05-12 15:00       ` [PATCH v4 12/27] target/i386/cpu: Remove CPUX86State::enable_cpuid_0xb field Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 13/27] target/i386/cpu: Remove CPUX86State::fill_mtrr_mask field Philippe Mathieu-Daudé
2025-05-09  9:30   ` Zhao Liu
2025-05-12 15:24   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 14/27] hw/intc/apic: Remove APICCommonState::legacy_instance_id field Philippe Mathieu-Daudé
2025-05-09  9:30   ` Zhao Liu
2025-05-13  8:34   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 15/27] hw/core/machine: Remove hw_compat_2_6[] array Philippe Mathieu-Daudé
2025-05-09  9:31   ` Zhao Liu
2025-05-13  8:36   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 16/27] hw/virtio/virtio-mmio: Remove VirtIOMMIOProxy::format_transport_address field Philippe Mathieu-Daudé
2025-05-09  9:33   ` Zhao Liu
2025-05-08 13:35 ` [PATCH v4 17/27] hw/i386/pc: Remove deprecated pc-q35-2.7 and pc-i440fx-2.7 machines Philippe Mathieu-Daudé
2025-05-09  9:33   ` Zhao Liu
2025-05-13  8:53   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 18/27] hw/i386/pc: Remove pc_compat_2_7[] array Philippe Mathieu-Daudé
2025-05-09  9:35   ` Zhao Liu
2025-05-08 13:35 ` [PATCH v4 19/27] target/i386/cpu: Remove CPUX86State::full_cpuid_auto_level field Philippe Mathieu-Daudé
2025-05-09  9:37   ` Zhao Liu
2025-05-13 11:02   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 20/27] target/i386/cpu: Remove CPUX86State::enable_l3_cache field Philippe Mathieu-Daudé
2025-05-09  9:11   ` Zhao Liu
2025-05-13 11:14     ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 21/27] hw/audio/pcspk: Remove PCSpkState::migrate field Philippe Mathieu-Daudé
2025-05-09  9:38   ` Zhao Liu
2025-05-13  9:02   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 22/27] hw/core/machine: Remove hw_compat_2_7[] array Philippe Mathieu-Daudé
2025-05-09  9:38   ` Zhao Liu
2025-05-08 13:35 ` [PATCH v4 23/27] hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field Philippe Mathieu-Daudé
2025-05-09  9:41   ` Zhao Liu
2025-05-13  9:16   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 24/27] hw/intc/ioapic: Remove IOAPICCommonState::version field Philippe Mathieu-Daudé
2025-05-09 10:32   ` Zhao Liu
2025-05-13 10:28   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 25/27] hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field Philippe Mathieu-Daudé
2025-05-09  9:43   ` Zhao Liu
2025-05-13 10:30   ` Igor Mammedov
2025-05-08 13:35 ` [PATCH v4 26/27] hw/char/virtio-serial: Do not expose the 'emergency-write' property Philippe Mathieu-Daudé
2025-05-09  9:13   ` Mark Cave-Ayland
2025-05-09  9:46   ` Zhao Liu
2025-05-08 13:35 ` [PATCH v4 27/27] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_PAGE_PER_VQ definition Philippe Mathieu-Daudé
2025-05-09 10:19   ` Zhao Liu
2025-05-13 10:48   ` Igor Mammedov
2025-05-13 11:23 ` [PATCH v4 00/27] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines Igor Mammedov
2025-05-30 11:35   ` Michael S. Tsirkin
2025-05-30 12:08     ` Peter Krempa
2025-05-30 12:50       ` Jiri Denemark
2025-06-17  6:54       ` Zhao Liu
2025-10-31 10:33 ` Igor Mammedov
2025-10-31 10:51   ` Philippe Mathieu-Daudé
2025-10-31 14:14     ` Zhao Liu
2025-10-31 14:23       ` Igor Mammedov
2025-11-03 15:05         ` Zhao Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aQjF5PdR0s/WrA3+@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=balaton@eik.bme.hu \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).