From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03D09CCF9E3 for ; Tue, 4 Nov 2025 11:04:33 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vGEpY-0007SF-R0; Tue, 04 Nov 2025 06:04:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vGEpW-0007Ri-7L for qemu-devel@nongnu.org; Tue, 04 Nov 2025 06:04:02 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vGEpU-00033D-Hk for qemu-devel@nongnu.org; Tue, 04 Nov 2025 06:04:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762254239; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cFYSCM6zygG6tz80BR8GZ6kKZ2uRCZ34QmiTQ9S0vDM=; b=ehmaidwzJ+/+susoheRJp9brMx2mWHQYinpzJEiYKzetl4PyPWdlBMl3Bnp4RtUse8/FJ5 q5UUNHY8ZLUjxCiIHrl/uV8XclFlauJDAVfl9IKdp0EnYoUJ4rVBiI0CmKpQpSfu7QjWbK PVRtXCURcv491aOTGZfvtUI/sWR1ILc= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-JSsmTRESOxyNoDaOlmPgww-1; Tue, 04 Nov 2025 06:03:53 -0500 X-MC-Unique: JSsmTRESOxyNoDaOlmPgww-1 X-Mimecast-MFC-AGG-ID: JSsmTRESOxyNoDaOlmPgww_1762254232 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 25BBD1956059; Tue, 4 Nov 2025 11:03:51 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.53]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A0041956056; Tue, 4 Nov 2025 11:03:49 +0000 (UTC) Date: Tue, 4 Nov 2025 11:03:45 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Eric Blake Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com Subject: Re: [PATCH 4/8] qio: Factor out helpers qio_net_listener_[un]watch Message-ID: References: <20251103202849.3687643-10-eblake@redhat.com> <20251103202849.3687643-14-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251103202849.3687643-14-eblake@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, Nov 03, 2025 at 02:10:55PM -0600, Eric Blake wrote: > The code had three similar repetitions of an iteration over one or all > of nsiocs to set up a GSource, and likewise for teardown. Since an > upcoming patch wants to tweak whether GSource or AioContext is used, > its better to consolidate that into one helper function for fewer > places to edit later. > > Signed-off-by: Eric Blake > --- > io/net-listener.c | 109 +++++++++++++++++++--------------------------- > 1 file changed, 45 insertions(+), 64 deletions(-) > > diff --git a/io/net-listener.c b/io/net-listener.c > index 15df673fb6e..e1378b9a612 100644 > --- a/io/net-listener.c > +++ b/io/net-listener.c > @@ -106,6 +106,45 @@ int qio_net_listener_open_sync(QIONetListener *listener, > } > } > void qio_net_listener_add(QIONetListener *listener, > QIOChannelSocket *sioc) > @@ -125,17 +164,7 @@ void qio_net_listener_add(QIONetListener *listener, > object_ref(OBJECT(sioc)); > listener->connected = true; > > - if (listener->io_func != NULL) { > - trace_qio_net_listener_watch_enabled(listener, listener->io_func, > - "add"); > - object_ref(OBJECT(listener)); > - listener->io_source[listener->nsioc] = qio_channel_add_watch_source( > - QIO_CHANNEL(listener->sioc[listener->nsioc]), G_IO_IN, > - qio_net_listener_channel_func, > - listener, (GDestroyNotify)object_unref, listener->context); > - } > - > - listener->nsioc++; > + qio_net_listener_watch(listener, listener->nsioc++, "add"); Nit-picking, I'd have a slight preference to keep the 'nsioc' increment on the following line from the qio_net_listener_watch call, as I don't like side effects in passing the function arguments. Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|