From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A4D8CCFA07 for ; Wed, 5 Nov 2025 09:36:26 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vGZw2-0001rr-T3; Wed, 05 Nov 2025 04:36:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vGZw1-0001rI-2F for qemu-devel@nongnu.org; Wed, 05 Nov 2025 04:36:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vGZvz-0003rk-LY for qemu-devel@nongnu.org; Wed, 05 Nov 2025 04:36:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762335367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PpiUqJ/fKYb4Uj7yuzvAcCDApHA/FZYjMKAsh0QT2JQ=; b=MLqF4Sk20RsN7NLR85WKs46l0oZxvSN2Qj3O7JaKZko7DqA3blWytIFGlpRt9xsRYLL+32 LjiCCYqjhKZXoiAoqwrmwqBndXdz2X7UE5Y9yatvINze9d0NEj5kV0i1CZVwoe8x4GbzXs RmfzSowGQvbEd8bjmyLgmUgSwkJvU3Y= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-346-2OtX0n7VOGGmTpZP1v9zlA-1; Wed, 05 Nov 2025 04:36:04 -0500 X-MC-Unique: 2OtX0n7VOGGmTpZP1v9zlA-1 X-Mimecast-MFC-AGG-ID: 2OtX0n7VOGGmTpZP1v9zlA_1762335363 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 14F8F1800473; Wed, 5 Nov 2025 09:36:03 +0000 (UTC) Received: from redhat.com (stefkas-mbp.str.redhat.com [10.33.192.245]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 35EAE300018D; Wed, 5 Nov 2025 09:36:01 +0000 (UTC) Date: Wed, 5 Nov 2025 10:35:58 +0100 From: Kevin Wolf To: Markus Armbruster Cc: =?iso-8859-1?Q?Cl=E9ment?= Chigot , qemu-devel@nongnu.org, hreitz@redhat.com, qemu-block@nongnu.org Subject: Re: [PATCH 5/5] vvfat: add support for "size" options Message-ID: References: <20250903075721.77623-1-chigot@adacore.com> <20250903075721.77623-6-chigot@adacore.com> <874ir9ot1a.fsf@pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874ir9ot1a.fsf@pond.sub.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.788, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 05.11.2025 um 08:08 hat Markus Armbruster geschrieben: > Kevin Wolf writes: > > [...] > > > To me it looks a bit like what we really want is an enum for floppy > > sizes (though is there any real reason why we have only those two?), but > > an arbitrary size for hard disks. > > > > Without the enum, obviously, users could specify 1440k and that would do > > the right thing. Maybe special casing whatever 1.44M and 2.88M result > > in and translating them into 1440k and 2880k could be more justifiable > > than special casing 1M and 2M, but it would still be ugly. > > > > Markus, do you have any advice how this should be represented in QAPI? > > Still want answers here? Yes, I'm still not sure how we could best represent both hard disk and floppy sizes in vvfat in a way that isn't completely counterintuitive for users, that also isn't just arbitrary magic and that works on the command line. Unless the need for different sizes has gone away, but I don't think we found any other solution for the problem that would not require a configurable disk/file system size? Kevin