From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Hanna Reitz <hreitz@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH] tests/qemu-iotests: Fix broken grep command in iotest 207
Date: Thu, 13 Nov 2025 09:18:19 +0000 [thread overview]
Message-ID: <aRWiW4cTKqArWZUu@redhat.com> (raw)
In-Reply-To: <20251113080525.444826-1-thuth@redhat.com>
On Thu, Nov 13, 2025 at 09:05:25AM +0100, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Running "./check -ssh 207" fails for me with lots of lines like this
> in the output:
>
> +base64: invalid input
>
> While looking closer at it, I noticed that the grep -v "\\^#" command
> in this test is not working as expected - it is likely meant to filter
> out the comment lines that are starting with a "#", but at least my
> version of grep (GNU grep 3.11) does not work with the backslashes here.
> There does not seem to be a compelling reason for these backslashes,
> so let's simply drop them to fix this issue.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/207 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-11-13 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-13 8:05 [PATCH] tests/qemu-iotests: Fix broken grep command in iotest 207 Thomas Huth
2025-11-13 9:18 ` Daniel P. Berrangé [this message]
2025-11-13 22:41 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRWiW4cTKqArWZUu@redhat.com \
--to=berrange@redhat.com \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).