From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA18FCD5BA9 for ; Thu, 13 Nov 2025 09:19:03 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vJTTh-00042G-Ue; Thu, 13 Nov 2025 04:18:54 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJTTW-0003zn-Gh for qemu-devel@nongnu.org; Thu, 13 Nov 2025 04:18:44 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vJTTU-00026K-7L for qemu-devel@nongnu.org; Thu, 13 Nov 2025 04:18:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763025519; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QRa8CIAY76d488cbmoAPQ9wWEMIhKx0j1XO5E7baqiM=; b=CCfFYyU27AcPiVWNRJgbKr7oX75fSxuv93nT6o25sgAD0+GFDQ9r4fD06Me4UtLxKqELY7 JS173g69VursYrG6c34jenlqiATkzW60cMidI7wJGfgZ3mf+8KuSCFstZkD2EafN8206X4 xBUuDvQKsI7L2F75qxoPYAwJatideRA= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-605-mXCMF5bcNDuIdwIFXBOUfQ-1; Thu, 13 Nov 2025 04:18:35 -0500 X-MC-Unique: mXCMF5bcNDuIdwIFXBOUfQ-1 X-Mimecast-MFC-AGG-ID: mXCMF5bcNDuIdwIFXBOUfQ_1763025514 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id BADA518AB419; Thu, 13 Nov 2025 09:18:34 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.56]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 25FF718004A3; Thu, 13 Nov 2025 09:18:30 +0000 (UTC) Date: Thu, 13 Nov 2025 09:18:19 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: Kevin Wolf , qemu-block@nongnu.org, Hanna Reitz , qemu-devel@nongnu.org Subject: Re: [PATCH] tests/qemu-iotests: Fix broken grep command in iotest 207 Message-ID: References: <20251113080525.444826-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251113080525.444826-1-thuth@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Nov 13, 2025 at 09:05:25AM +0100, Thomas Huth wrote: > From: Thomas Huth > > Running "./check -ssh 207" fails for me with lots of lines like this > in the output: > > +base64: invalid input > > While looking closer at it, I noticed that the grep -v "\\^#" command > in this test is not working as expected - it is likely meant to filter > out the comment lines that are starting with a "#", but at least my > version of grep (GNU grep 3.11) does not work with the backslashes here. > There does not seem to be a compelling reason for these backslashes, > so let's simply drop them to fix this issue. > > Signed-off-by: Thomas Huth > --- > tests/qemu-iotests/207 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|