Re: [PATCH-for-10.2] hw/arm: Re-enable xenpvh machine in qemu-system-arm/aarch64 binaries

["Edgar E. Iglesias" via <qemu-devel@nongnu.org>]

On Mon, Nov 17, 2025 at 10:12:53AM +0100, Philippe Mathieu-Daudé wrote:
> While registering the ARM/Aarch64 machine interfaces
> in commit 38c5ab40031 ("hw/arm: Filter machine types
> for qemu-system-arm/aarch64 binaries"), we missed the
> XenPV machine. Correct that.
> 
> Reported-by: Edgar E. Iglesias <edgar.iglesias@amd.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Tested-by: Edgar E. Iglesias <edgar.iglesias@amd.com>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@amd.com>




> ---
> 1/ Review got likely unnoticed by Xen folks because no
>    Xen-specific entry in MAINTAINERS:
> 
>    $ ./scripts/get_maintainer.pl -f hw/arm/xen-pvh.c
>    Peter Maydell <peter.maydell@linaro.org> (maintainer:ARM TCG CPUs)
>    qemu-arm@nongnu.org (open list:ARM TCG CPUs)
>    qemu-devel@nongnu.org (open list:All patches CC here)
> 
> 2/ Should we restrict it to aa64 only?
> ---
>  hw/arm/xen-pvh.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/arm/xen-pvh.c b/hw/arm/xen-pvh.c
> index 1a9eeb01c8e..86a02966161 100644
> --- a/hw/arm/xen-pvh.c
> +++ b/hw/arm/xen-pvh.c
> @@ -10,6 +10,7 @@
>  #include "hw/boards.h"
>  #include "system/system.h"
>  #include "hw/xen/xen-pvh-common.h"
> +#include "hw/arm/machines-qom.h"
>  
>  #define TYPE_XEN_ARM  MACHINE_TYPE_NAME("xenpvh")
>  
> @@ -95,6 +96,7 @@ static const TypeInfo xen_arm_machine_type = {
>      .class_init = xen_arm_machine_class_init,
>      .instance_size = sizeof(XenPVHMachineState),
>      .instance_init = xen_arm_instance_init,
> +    .interfaces = arm_aarch64_machine_interfaces,
>  };
>  
>  static void xen_arm_machine_register_types(void)
> -- 
> 2.51.0
>