Re: [PATCH 17/22] tests: forcibly run 'make check-venv' for crash tests

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Nov 17, 2025 at 01:51:25PM -0500, John Snow wrote:
> In order to convert the existing Makefile target from a manual
> invocation of mkvenv to one that uses the meson dependency system, we
> need to not suppress ninja here.
> 
> I'm not sure if this creates problems I am not aware of; but invoking
> ninja here is no longer spurious but will become necessary.

Yes, this will likely create problems. From the commit message that
introduced NINJA=":"...

  commit 4d3bd91b26a69b39a178744d3d6e5f23050afb23
  Author: Thomas Huth <thuth@redhat.com>
  Date:   Mon Apr 24 10:22:35 2023 +0100

    gitlab-ci: Avoid to re-run "configure" in the device-crash-test jobs
    
    After "make check-venv" had been added to these jobs, they started
    to re-run "configure" each time since our logic in the makefile
    thinks that some files are out of date here. Avoid it with the same
    trick that we are using in buildtest-template.yml already by disabling
    the up-to-date check via NINJA=":".



> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  .gitlab-ci.d/buildtest.yml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index 18d72d3058b..2cb2cf25b4a 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -101,7 +101,7 @@ crash-test-debian:
>      IMAGE: debian
>    script:
>      - cd build
> -    - make NINJA=":" check-venv
> +    - make check-venv
>      - pyvenv/bin/python3 scripts/device-crash-test -q --tcg-only ./qemu-system-i386
>  
>  build-system-fedora:
> @@ -158,7 +158,7 @@ crash-test-fedora:
>      IMAGE: fedora
>    script:
>      - cd build
> -    - make NINJA=":" check-venv
> +    - make check-venv
>      - pyvenv/bin/python3 scripts/device-crash-test -q ./qemu-system-ppc
>      - pyvenv/bin/python3 scripts/device-crash-test -q ./qemu-system-riscv32
>  
> -- 
> 2.51.1
> 

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|