From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 199F4CEE328 for ; Tue, 18 Nov 2025 16:02:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLO99-0007RP-2G; Tue, 18 Nov 2025 11:01:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLO95-0007Qh-6e for qemu-devel@nongnu.org; Tue, 18 Nov 2025 11:01:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLO93-0003TX-89 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 11:01:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763481688; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iAFUZzZX2cLK6mda/tv6xz08CXSSaLxTm2mfYCx1OCk=; b=E0tx5FfpAujbWO/A3vIkefmk14Hopr0QUo6wRUVVRYNm5v4AA3IstfSXRWse5m5i4ZpAWp bAmljsR5v+vL2E85mm+R3wz3ANXS2RzyRSJ/5iuAs6ZSkjWgCZW3umT9p2lf2rEtMqWJP2 8fQ5T6qblt0q+RSYDy6Jqj6/LeW5kOY= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-g4KyzlvlMhmRyLFT-m-Zjg-1; Tue, 18 Nov 2025 11:01:16 -0500 X-MC-Unique: g4KyzlvlMhmRyLFT-m-Zjg-1 X-Mimecast-MFC-AGG-ID: g4KyzlvlMhmRyLFT-m-Zjg_1763481675 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 639181800581 for ; Tue, 18 Nov 2025 16:01:15 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.53]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3BE6219560B0; Tue, 18 Nov 2025 16:01:13 +0000 (UTC) Date: Tue, 18 Nov 2025 16:01:09 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, jasowang@redhat.com, mst@redhat.com Subject: Re: [PATCH 1/3] ebpf: Fix stubs to set an error when they return failure Message-ID: References: <20251118154718.3969982-1-armbru@redhat.com> <20251118154718.3969982-2-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251118154718.3969982-2-armbru@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Nov 18, 2025 at 04:47:16PM +0100, Markus Armbruster wrote: > Stubs in ebpf_rss-stub.c return false for failure without setting an > Error. This is wrong. Callers may assume that the functions set an > error when they fail, and crash when they try to examine or report the > error. Callers may also check the error instead of the return value, > and misinterpret the failure as success. > > ebpf_rss_load() and ebpf_rss_load() are reachable via > virtio_net_load_ebpf(). Fix them to set an error. > > ebpf_rss_set_all() is unreachable: it can only be called when the > context has an eBPF program loaded, which is impossible with eBPF > support compiled out. Call abort() there to make that clear, and to > get rid of the latent bug. > > Fixes: 00b69f1d867d (ebpf: add formal error reporting to all APIs) > Signed-off-by: Markus Armbruster > --- > ebpf/ebpf_rss-stub.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|