From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, jasowang@redhat.com, mst@redhat.com
Subject: Re: [PATCH 2/3] ebpf: Clean up useless error check in ebpf_rss_set_all()
Date: Tue, 18 Nov 2025 16:01:30 +0000 [thread overview]
Message-ID: <aRyYWpxLO9wz0LDS@redhat.com> (raw)
In-Reply-To: <20251118154718.3969982-3-armbru@redhat.com>
On Tue, Nov 18, 2025 at 04:47:17PM +0100, Markus Armbruster wrote:
> ebpf_rss_set_all() is only called when the context has an eBPF program
> loaded. Replace the dead error check with an assertion.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> ebpf/ebpf_rss.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2025-11-18 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 15:47 [PATCH 0/3] ebpf: Error fixes and cleanups Markus Armbruster
2025-11-18 15:47 ` [PATCH 1/3] ebpf: Fix stubs to set an error when they return failure Markus Armbruster
2025-11-18 16:01 ` Daniel P. Berrangé
2025-11-18 15:47 ` [PATCH 2/3] ebpf: Clean up useless error check in ebpf_rss_set_all() Markus Armbruster
2025-11-18 16:01 ` Daniel P. Berrangé [this message]
2025-11-18 15:47 ` [PATCH 3/3] ebpf: Make ebpf_rss_load() return value consistent with @errp Markus Armbruster
2025-11-18 16:03 ` Daniel P. Berrangé
2025-11-18 18:31 ` [PATCH 0/3] ebpf: Error fixes and cleanups Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aRyYWpxLO9wz0LDS@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).