From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E403CEE328 for ; Tue, 18 Nov 2025 16:03:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vLOAr-000858-Ar; Tue, 18 Nov 2025 11:03:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLOAp-00080T-UE for qemu-devel@nongnu.org; Tue, 18 Nov 2025 11:03:19 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vLOAo-0003uf-A3 for qemu-devel@nongnu.org; Tue, 18 Nov 2025 11:03:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763481797; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5qZo/xEyuiSOpgLdH+ao4Z2aA6k406SxZmBY9PelvF0=; b=RV+3TTUnmdzVt95MwKW1+fiwsT1hh3ZU+64t1gczRPiR+y/Z11ZOlsfRPi9gIGN1Hm4Loo mHACyhoxdt0WmgMjtu+xjUEnaorP+0k07pA7utcqPFer/TmcNfSooaGWa9SYEy8NlsfM+C c6CxoER21RGa7/LTPX5rLTQvNQrsorw= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-224-slyuZwL8Nsqtq6QMxB-3Nw-1; Tue, 18 Nov 2025 11:03:14 -0500 X-MC-Unique: slyuZwL8Nsqtq6QMxB-3Nw-1 X-Mimecast-MFC-AGG-ID: slyuZwL8Nsqtq6QMxB-3Nw_1763481793 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C715E191B4E6 for ; Tue, 18 Nov 2025 16:03:13 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.53]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E57C43003754; Tue, 18 Nov 2025 16:03:11 +0000 (UTC) Date: Tue, 18 Nov 2025 16:03:07 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, jasowang@redhat.com, mst@redhat.com Subject: Re: [PATCH 3/3] ebpf: Make ebpf_rss_load() return value consistent with @errp Message-ID: References: <20251118154718.3969982-1-armbru@redhat.com> <20251118154718.3969982-4-armbru@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20251118154718.3969982-4-armbru@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Nov 18, 2025 at 04:47:18PM +0100, Markus Armbruster wrote: > ebpf_rss_load() returns false for failure without setting an Error > when its @ctx argument already has an eBPF program loaded. This is > wrong. Fortunately, it is only called @ctx has a program. Replace > the incorrect error check by an assertion. > > The return value is now obviously reliable. Change the caller to use > it, because it's more concise. > > Signed-off-by: Markus Armbruster > --- > ebpf/ebpf_rss.c | 4 +--- > hw/net/virtio-net.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|