From: Zhao Liu <zhao1.liu@intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-rust@nongnu.org
Subject: Re: [PATCH 4/9] rust/bql: make bindings public
Date: Wed, 3 Dec 2025 18:58:56 +0800 [thread overview]
Message-ID: <aTAX8PJgUIv19+Yg@intel.com> (raw)
In-Reply-To: <20251127132036.84384-5-pbonzini@redhat.com>
On Thu, Nov 27, 2025 at 02:20:31PM +0100, Paolo Bonzini wrote:
> Date: Thu, 27 Nov 2025 14:20:31 +0100
> From: Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 4/9] rust/bql: make bindings public
> X-Mailer: git-send-email 2.51.1
>
> For consistency with other crates.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> rust/bql/src/lib.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Other crates appear to require being public mods to ensure binding
compilation succeeds or to use raw binding in somewhere, but currently
bql's raw binding hasn't been used anywhere.
I think maybe it's better to keep this mod as private until someone
needs it. This helps justify whether raw binding is truly necessary.
Direct binding uses should be minimized if possible.
Thanks,
Zhao
next prev parent reply other threads:[~2025-12-03 10:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-27 13:20 [PATCH 0/9] rust: build system and other cleanups Paolo Bonzini
2025-11-27 13:20 ` [PATCH 1/9] rust: remove leftover bindings/ Paolo Bonzini
2025-12-03 9:11 ` Zhao Liu
2025-11-27 13:20 ` [PATCH 2/9] rust: remove unused --cfg arguments Paolo Bonzini
2025-12-03 10:25 ` Zhao Liu
2025-11-27 13:20 ` [PATCH 3/9] rust: remove unnecessary repetitive options Paolo Bonzini
2025-12-03 10:37 ` Zhao Liu
2025-11-27 13:20 ` [PATCH 4/9] rust/bql: make bindings public Paolo Bonzini
2025-12-03 10:58 ` Zhao Liu [this message]
2025-11-27 13:20 ` [PATCH 5/9] rust: do not copy the SysBusDevice Paolo Bonzini
2025-12-03 10:59 ` Zhao Liu
2025-11-27 13:20 ` [PATCH 6/9] rust: fix reference to MemoryRegion Paolo Bonzini
2025-12-03 11:00 ` Zhao Liu
2025-11-27 13:20 ` [PATCH 7/9] rust: move strict lints handling to meson.build Paolo Bonzini
2025-12-03 15:29 ` Zhao Liu
2025-11-27 13:20 ` [PATCH 8/9] rust: Do not link qemuutil into Rust rlibs Paolo Bonzini
2025-11-27 13:20 ` [PATCH 9/9] rust: only link the Rust part of the code into devices Paolo Bonzini
2025-12-03 9:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aTAX8PJgUIv19+Yg@intel.com \
--to=zhao1.liu@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-rust@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).