* [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage()
@ 2025-12-08 7:53 Thomas Huth
2025-12-08 11:10 ` Laurent Vivier
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Thomas Huth @ 2025-12-08 7:53 UTC (permalink / raw)
To: Kevin Wolf, qemu-block, Eric Blake
Cc: qemu-devel, Hanna Reitz, Fiona Ebner, qemu-trivial
From: Thomas Huth <thuth@redhat.com>
Looks like the "$" has been forgotten here to get the contents of
the FILENAME variable.
Fixes: c49dda7254d ("iotests: Filter out ZFS in several tests")
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qemu-iotests/common.rc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index 10d83d8361b..c0f8f0f8dfa 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -1008,7 +1008,7 @@ _require_disk_usage()
else
FILENAME="$TEST_IMG_FILE"
fi
- if [ -e "FILENAME" ]; then
+ if [ -e "$FILENAME" ]; then
echo "unwilling to overwrite existing file"
exit 1
fi
--
2.52.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage()
2025-12-08 7:53 [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage() Thomas Huth
@ 2025-12-08 11:10 ` Laurent Vivier
2025-12-09 7:11 ` Philippe Mathieu-Daudé
2025-12-09 10:48 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Vivier @ 2025-12-08 11:10 UTC (permalink / raw)
To: Thomas Huth
Cc: Kevin Wolf, qemu-block, Eric Blake, qemu-devel, Hanna Reitz,
Fiona Ebner, qemu-trivial
On Mon, 8 Dec 2025 08:53:20 +0100 Thomas Huth <thuth@redhat.com> wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Looks like the "$" has been forgotten here to get the contents of
> the FILENAME variable.
>
> Fixes: c49dda7254d ("iotests: Filter out ZFS in several tests")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/common.rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
> index 10d83d8361b..c0f8f0f8dfa 100644
> --- a/tests/qemu-iotests/common.rc
> +++ b/tests/qemu-iotests/common.rc
> @@ -1008,7 +1008,7 @@ _require_disk_usage()
> else
> FILENAME="$TEST_IMG_FILE"
> fi
> - if [ -e "FILENAME" ]; then
> + if [ -e "$FILENAME" ]; then
> echo "unwilling to overwrite existing file"
> exit 1
> fi
> --
> 2.52.0
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage()
2025-12-08 7:53 [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage() Thomas Huth
2025-12-08 11:10 ` Laurent Vivier
@ 2025-12-09 7:11 ` Philippe Mathieu-Daudé
2025-12-09 10:48 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2025-12-09 7:11 UTC (permalink / raw)
To: Thomas Huth, Kevin Wolf, qemu-block, Eric Blake
Cc: qemu-devel, Hanna Reitz, Fiona Ebner, qemu-trivial
On 8/12/25 08:53, Thomas Huth wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> Looks like the "$" has been forgotten here to get the contents of
> the FILENAME variable.
>
> Fixes: c49dda7254d ("iotests: Filter out ZFS in several tests")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> tests/qemu-iotests/common.rc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage()
2025-12-08 7:53 [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage() Thomas Huth
2025-12-08 11:10 ` Laurent Vivier
2025-12-09 7:11 ` Philippe Mathieu-Daudé
@ 2025-12-09 10:48 ` Kevin Wolf
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Wolf @ 2025-12-09 10:48 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-block, Eric Blake, qemu-devel, Hanna Reitz, Fiona Ebner,
qemu-trivial
Am 08.12.2025 um 08:53 hat Thomas Huth geschrieben:
> From: Thomas Huth <thuth@redhat.com>
>
> Looks like the "$" has been forgotten here to get the contents of
> the FILENAME variable.
>
> Fixes: c49dda7254d ("iotests: Filter out ZFS in several tests")
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to the block branch.
Kevin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-09 10:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-08 7:53 [PATCH] tests/qemu-iotests: Fix check for existing file in _require_disk_usage() Thomas Huth
2025-12-08 11:10 ` Laurent Vivier
2025-12-09 7:11 ` Philippe Mathieu-Daudé
2025-12-09 10:48 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).