Re: [PATCH 0/5] contrib/plugins/hotblocks: Minor bug fixes and add limit argument

[Pierrick Bouvier <pierrick.bouvier@linaro.org>]

On 7/29/25 11:41 PM, Alex Bradbury wrote:
> This series contains one minor feature addition and a series of small
> bugfixes/improvements. The addition that motivates the submission is to add a
> limit argument for the hotblocks plugin, allowing you to control how many
> blocks are printed rather than being hardcoded to the 20 most executed.
> Setting limit=0 and dumping information about all executed blocks is
> incredibly helpful for an analysis script I have downstream.
> 
> This is my first contribution to QEMU. I've attempted to follow all of the
> guidance in the "Submitting a Patch" guide, but apologies if I missed
> anything.
>

Thanks for contributing Alex.

As you probably read, in case a v2 is expected (the plugins maintainer 
Alex will be back next week, he might have additional comments), you can 
add the "Reviewed-by" tags you already collected to your commits by 
ammending their messages.
For the rest, your series looks good to me.

Regards,
Pierrick

> Alex Bradbury (5):
>    contrib/plugins/hotblocks: Correctly free sorted counts list
>    contrib/plugins/hotblocks: Fix off by one error in iteration of sorted
>      blocks
>    contrib/plugins/hotblocks: Print uint64_t with PRIu64 rather than
>      PRId64
>    docs/about/emulation: Add documentation for hotblocks plugin arguments
>    contrib/plugins/hotblocks: Allow limit to be set as a command line
>      argument
> 
>   contrib/plugins/hotblocks.c | 20 ++++++++++++++------
>   docs/about/emulation.rst    | 12 ++++++++++++
>   2 files changed, 26 insertions(+), 6 deletions(-)
>