From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:47149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMQPC-0000fa-Dq for qemu-devel@nongnu.org; Fri, 03 May 2019 01:06:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMQPB-0003Ou-8f for qemu-devel@nongnu.org; Fri, 03 May 2019 01:06:42 -0400 References: <20190503002206.9751-1-driver1998@foxmail.com> <20190503003618.10089-1-driver1998@foxmail.com> From: Thomas Huth Message-ID: Date: Fri, 3 May 2019 07:06:34 +0200 MIME-Version: 1.0 In-Reply-To: <20190503003618.10089-1-driver1998@foxmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/4] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao Jiaxi , qemu-devel@nongnu.org Cc: QEMU Trivial , Stefan Weil , Samuel Thibault , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= On 03/05/2019 02.36, Cao Jiaxi wrote: > gcc_struct is for x86 only, and it generates an warning on ARM64 Clang/MinGW targets. > > Signed-off-by: Cao Jiaxi > --- > contrib/libvhost-user/libvhost-user.h | 2 +- > include/qemu/compiler.h | 2 +- > scripts/cocci-macro-file.h | 7 ++++++- > slirp/src/util.h | 2 +- > 4 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h > index 414ceb0a2f..78b33306e8 100644 > --- a/contrib/libvhost-user/libvhost-user.h > +++ b/contrib/libvhost-user/libvhost-user.h > @@ -148,7 +148,7 @@ typedef struct VhostUserInflight { > uint16_t queue_size; > } VhostUserInflight; > > -#if defined(_WIN32) > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > # define VU_PACKED __attribute__((gcc_struct, packed)) > #else > # define VU_PACKED __attribute__((packed)) > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index 296b2fd572..09fc44cca4 100644 > --- a/include/qemu/compiler.h > +++ b/include/qemu/compiler.h > @@ -28,7 +28,7 @@ > > #define QEMU_SENTINEL __attribute__((sentinel)) > > -#if defined(_WIN32) > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > # define QEMU_PACKED __attribute__((gcc_struct, packed)) > #else > # define QEMU_PACKED __attribute__((packed)) > diff --git a/scripts/cocci-macro-file.h b/scripts/cocci-macro-file.h > index e485cdccae..c6bbc05ba3 100644 > --- a/scripts/cocci-macro-file.h > +++ b/scripts/cocci-macro-file.h > @@ -23,7 +23,12 @@ > #define QEMU_NORETURN __attribute__ ((__noreturn__)) > #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) > #define QEMU_SENTINEL __attribute__((sentinel)) > -#define QEMU_PACKED __attribute__((gcc_struct, packed)) > + > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > +# define QEMU_PACKED __attribute__((gcc_struct, packed)) > +#else > +# define QEMU_PACKED __attribute__((packed)) > +#endif > > #define cat(x,y) x ## y > #define cat2(x,y) cat(x,y) > diff --git a/slirp/src/util.h b/slirp/src/util.h > index 01f1e0e068..278828fe3f 100644 > --- a/slirp/src/util.h > +++ b/slirp/src/util.h > @@ -43,7 +43,7 @@ > #include > #endif > > -#if defined(_WIN32) > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > # define SLIRP_PACKED __attribute__((gcc_struct, packed)) > #else > # define SLIRP_PACKED __attribute__((packed)) > The slirp code is currently on its way into a separate module, so you might need to provide that hunk to the libslirp folks again... I'm putting the slirp maintainers on CC:, maybe they can pick it up from here. Anyway: Reviewed-by: Thomas Huth From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57538C43219 for ; Fri, 3 May 2019 05:07:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 18890205F4 for ; Fri, 3 May 2019 05:07:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18890205F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:34517 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMQQ5-00012f-3b for qemu-devel@archiver.kernel.org; Fri, 03 May 2019 01:07:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMQPC-0000fa-Dq for qemu-devel@nongnu.org; Fri, 03 May 2019 01:06:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMQPB-0003Ou-8f for qemu-devel@nongnu.org; Fri, 03 May 2019 01:06:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hMQPA-0003OW-VQ; Fri, 03 May 2019 01:06:41 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A0AB730ADBBE; Fri, 3 May 2019 05:06:39 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-70.ams2.redhat.com [10.36.116.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id A218A600C5; Fri, 3 May 2019 05:06:35 +0000 (UTC) To: Cao Jiaxi , qemu-devel@nongnu.org References: <20190503002206.9751-1-driver1998@foxmail.com> <20190503003618.10089-1-driver1998@foxmail.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: Date: Fri, 3 May 2019 07:06:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503003618.10089-1-driver1998@foxmail.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Fri, 03 May 2019 05:06:40 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v3 1/4] QEMU_PACKED: Remove gcc_struct attribute in Windows non x86 targets X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Stefan Weil , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Samuel Thibault Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190503050634.HuGe4CJPuq8DOK7XpZeZmKcKXDkU36f2v40REHjI7nU@z> On 03/05/2019 02.36, Cao Jiaxi wrote: > gcc_struct is for x86 only, and it generates an warning on ARM64 Clang/MinGW targets. > > Signed-off-by: Cao Jiaxi > --- > contrib/libvhost-user/libvhost-user.h | 2 +- > include/qemu/compiler.h | 2 +- > scripts/cocci-macro-file.h | 7 ++++++- > slirp/src/util.h | 2 +- > 4 files changed, 9 insertions(+), 4 deletions(-) > > diff --git a/contrib/libvhost-user/libvhost-user.h b/contrib/libvhost-user/libvhost-user.h > index 414ceb0a2f..78b33306e8 100644 > --- a/contrib/libvhost-user/libvhost-user.h > +++ b/contrib/libvhost-user/libvhost-user.h > @@ -148,7 +148,7 @@ typedef struct VhostUserInflight { > uint16_t queue_size; > } VhostUserInflight; > > -#if defined(_WIN32) > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > # define VU_PACKED __attribute__((gcc_struct, packed)) > #else > # define VU_PACKED __attribute__((packed)) > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index 296b2fd572..09fc44cca4 100644 > --- a/include/qemu/compiler.h > +++ b/include/qemu/compiler.h > @@ -28,7 +28,7 @@ > > #define QEMU_SENTINEL __attribute__((sentinel)) > > -#if defined(_WIN32) > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > # define QEMU_PACKED __attribute__((gcc_struct, packed)) > #else > # define QEMU_PACKED __attribute__((packed)) > diff --git a/scripts/cocci-macro-file.h b/scripts/cocci-macro-file.h > index e485cdccae..c6bbc05ba3 100644 > --- a/scripts/cocci-macro-file.h > +++ b/scripts/cocci-macro-file.h > @@ -23,7 +23,12 @@ > #define QEMU_NORETURN __attribute__ ((__noreturn__)) > #define QEMU_WARN_UNUSED_RESULT __attribute__((warn_unused_result)) > #define QEMU_SENTINEL __attribute__((sentinel)) > -#define QEMU_PACKED __attribute__((gcc_struct, packed)) > + > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > +# define QEMU_PACKED __attribute__((gcc_struct, packed)) > +#else > +# define QEMU_PACKED __attribute__((packed)) > +#endif > > #define cat(x,y) x ## y > #define cat2(x,y) cat(x,y) > diff --git a/slirp/src/util.h b/slirp/src/util.h > index 01f1e0e068..278828fe3f 100644 > --- a/slirp/src/util.h > +++ b/slirp/src/util.h > @@ -43,7 +43,7 @@ > #include > #endif > > -#if defined(_WIN32) > +#if defined(_WIN32) && (defined(__x86_64__) || defined(__i386__)) > # define SLIRP_PACKED __attribute__((gcc_struct, packed)) > #else > # define SLIRP_PACKED __attribute__((packed)) > The slirp code is currently on its way into a separate module, so you might need to provide that hunk to the libslirp folks again... I'm putting the slirp maintainers on CC:, maybe they can pick it up from here. Anyway: Reviewed-by: Thomas Huth