From: Pierrick Bouvier <pierrick.bouvier@linaro.org>
To: "Thomas Huth" <thuth@redhat.com>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>
Cc: qemu-stable@nongnu.org
Subject: Re: [PATCH] contrib/plugins/Makefile: Add a 'distclean' target
Date: Mon, 2 Sep 2024 09:08:47 -0700 [thread overview]
Message-ID: <aa158937-536e-4bdb-b011-0c4fc152ebaa@linaro.org> (raw)
In-Reply-To: <20240902154749.73876-1-thuth@redhat.com>
On 9/2/24 08:47, Thomas Huth wrote:
> Running "make distclean" in the build tree currently fails since this
> tries to run the "distclean" target in the contrib/plugins/ folder, too,
> but the Makefile there is missing this target. Thus add 'distclean' there
> to fix this issue.
>
> And to avoid regressions with "make distclean", add this command to one
> of the build jobs, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> .gitlab-ci.d/buildtest.yml | 2 ++
> contrib/plugins/Makefile | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
> index aa32782405..0c624813cf 100644
> --- a/.gitlab-ci.d/buildtest.yml
> +++ b/.gitlab-ci.d/buildtest.yml
> @@ -345,6 +345,8 @@ build-tcg-disabled:
> 124 132 139 142 144 145 151 152 155 157 165 194 196 200 202
> 208 209 216 218 227 234 246 247 248 250 254 255 257 258
> 260 261 262 263 264 270 272 273 277 279 image-fleecing
> + - cd ../..
> + - make distclean
>
> build-user:
> extends: .native_build_job_template
> diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile
> index edf256cd9d..05a2a45c5c 100644
> --- a/contrib/plugins/Makefile
> +++ b/contrib/plugins/Makefile
> @@ -77,7 +77,7 @@ lib%$(SO_SUFFIX): %.o
> endif
>
>
> -clean:
> +clean distclean:
> rm -f *.o *$(SO_SUFFIX) *.d
> rm -Rf .libs
>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
next prev parent reply other threads:[~2024-09-02 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 15:47 [PATCH] contrib/plugins/Makefile: Add a 'distclean' target Thomas Huth
2024-09-02 16:08 ` Pierrick Bouvier [this message]
2024-09-02 18:58 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa158937-536e-4bdb-b011-0c4fc152ebaa@linaro.org \
--to=pierrick.bouvier@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=erdnaxe@crans.org \
--cc=ma.mandourr@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).