From: Julian Kirsch <git@kirschju.re>
To: Eduardo Habkost <ehabkost@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] X86/HMP: Expose x86 model specific registers via human monitor
Date: Wed, 8 Mar 2017 17:08:42 +0100 [thread overview]
Message-ID: <aa16a480-d3cd-e73c-00d4-947bc0b95deb@kirschju.re> (raw)
In-Reply-To: <20170308135751.GE4694@thinpad.lan.raisama.net>
On 08.03.2017 14:57, Eduardo Habkost wrote:
>>
>> This should be abstracted some how so that we don't need
>> x86 specifics in cpus.c; perhaps just an architecture call
>> back on the CPU.
>
> If it's only supported by x86, I would just move the
> implementation to a x86-specific file, and add a stub for the
> other architectures. See qmp_query_gic_capabilities() for an
> example.
>
> Also, the command should be added to
> qmp_unregister_commands_hack() so we don't even report it as
> available on other architectures.
>
Awesome, thanks for your comments, I'll move the qmp commands to
target/i386/monitor.c and unregister them for architectures other than I386. Do
I have to explicitly take care of unregistering the hmp commands as well?
-Julian
next prev parent reply other threads:[~2017-03-08 16:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170308001637.9838-1-git@kirschju.re>
2017-03-08 2:36 ` [Qemu-devel] [PATCH] X86/HMP: Expose x86 model specific registers via human monitor Eric Blake
2017-03-08 8:26 ` Julian Kirsch
2017-03-10 14:09 ` Igor Mammedov
2017-03-10 16:11 ` Julian Kirsch
2017-03-08 3:09 ` Richard Henderson
2017-03-08 11:34 ` Julian Kirsch
2017-03-08 11:59 ` Dr. David Alan Gilbert
2017-03-08 13:57 ` Eduardo Habkost
2017-03-08 16:08 ` Julian Kirsch [this message]
2017-03-08 18:44 ` Eduardo Habkost
2017-03-09 16:32 ` Paolo Bonzini
2017-03-09 17:27 ` Eduardo Habkost
2017-03-09 18:05 ` Julian Kirsch
2017-03-08 15:40 ` Julian Kirsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa16a480-d3cd-e73c-00d4-947bc0b95deb@kirschju.re \
--to=git@kirschju.re \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).