Re: [Qemu-devel] [PATCH 2/3] target/mips: Switch to do_transaction_failed() hook

["Hervé Poussineau" <hpoussin@reactos.org>]

Le 02/08/2019 à 18:04, Peter Maydell a écrit :
> Switch the MIPS target from the old unassigned_access hook to the new
> do_transaction_failed hook.
> 
> Unlike the old hook, do_transaction_failed is only ever called from
> the TCG memory access paths, so there is no need for the "ignore this
> if we're using KVM" hack that we were previously using to work around
> the way unassigned_access was called for all kinds of memory accesses
> to unassigned physical addresses.
> 
> The MIPS target does not ever do direct memory reads by physical
> address (via either ldl_phys etc or address_space_ldl etc), so the
> only memory accesses this affects are the 'normal' guest loads and
> stores, which will be handled by the new hook; their behaviour is
> unchanged.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   target/mips/internal.h  |  8 +++++---
>   target/mips/cpu.c       |  2 +-
>   target/mips/op_helper.c | 24 ++++++++----------------
>   3 files changed, 14 insertions(+), 20 deletions(-)

Tested-by: Hervé Poussineau <hpoussin@reactos.org>