From: Richard Henderson <richard.henderson@linaro.org>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: marex@denx.de, pbonzini@redhat.com, crwulff@gmail.com,
qemu-trivial <qemu-trivial@nongnu.org>,
Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH] target/nios2: fix page-fit instruction count
Date: Tue, 25 May 2021 07:28:27 -0700 [thread overview]
Message-ID: <aa23def1-fdf1-905c-94fc-954fea420762@linaro.org> (raw)
In-Reply-To: <7ff230df-8173-1dae-3750-a40b0588f13d@ispras.ru>
Laurent, how about through trivial?
r~
On 5/24/21 11:40 PM, Pavel Dovgalyuk wrote:
> ping
>
> On 11.05.2021 11:40, Pavel Dovgalyuk wrote:
>> This patch fixes calculation of number of the instructions
>> that fit the current page. It prevents creation of the translation
>> blocks that cross the page boundaries. It is required for deterministic
>> exception generation in icount mode.
>>
>> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> target/nios2/translate.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/target/nios2/translate.c b/target/nios2/translate.c
>> index 9824544eb3..399f22d938 100644
>> --- a/target/nios2/translate.c
>> +++ b/target/nios2/translate.c
>> @@ -829,7 +829,7 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock
>> *tb, int max_insns)
>> /* Set up instruction counts */
>> num_insns = 0;
>> if (max_insns > 1) {
>> - int page_insns = (TARGET_PAGE_SIZE - (tb->pc & TARGET_PAGE_MASK)) / 4;
>> + int page_insns = (TARGET_PAGE_SIZE - (tb->pc & ~TARGET_PAGE_MASK)) / 4;
>> if (max_insns > page_insns) {
>> max_insns = page_insns;
>> }
>>
>
next prev parent reply other threads:[~2021-05-25 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 8:40 [PATCH] target/nios2: fix page-fit instruction count Pavel Dovgalyuk
2021-05-25 6:40 ` Pavel Dovgalyuk
2021-05-25 14:28 ` Richard Henderson [this message]
2021-06-05 19:17 ` Laurent Vivier
-- strict thread matches above, loose matches on Subject: below --
2021-04-05 8:20 Pavel Dovgalyuk
2021-04-05 14:44 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa23def1-fdf1-905c-94fc-954fea420762@linaro.org \
--to=richard.henderson@linaro.org \
--cc=crwulff@gmail.com \
--cc=laurent@vivier.eu \
--cc=marex@denx.de \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).