From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Huacai Chen <zltjiangshi@gmail.com>,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH 2/2] hw/mips: Simplify code using ROUND_UP(INITRD_PAGE_SIZE)
Date: Mon, 5 Oct 2020 08:37:02 -0500 [thread overview]
Message-ID: <aa3c770e-b1c5-261c-e0e0-42fb84677600@linaro.org> (raw)
In-Reply-To: <20200927163943.614604-3-f4bug@amsat.org>
On 9/27/20 11:39 AM, Philippe Mathieu-Daudé wrote:
> Instead of using a INITRD_PAGE_MASK definition, use the
> simpler INITRD_PAGE_SIZE one which allows us to simplify
> the code by using directly the self-explicit ROUND_UP()
> macro.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> include/hw/mips/mips.h | 4 +++-
> hw/mips/fuloong2e.c | 3 +--
> hw/mips/malta.c | 6 +++---
> hw/mips/mipssim.c | 3 +--
> hw/mips/r4k.c | 3 +--
> 5 files changed, 9 insertions(+), 10 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-10-05 13:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 16:39 [PATCH 0/2] hw/mips: Code simplifications Philippe Mathieu-Daudé
2020-09-27 16:39 ` [PATCH 1/2] hw/mips: Simplify loading 64-bit ELF kernels Philippe Mathieu-Daudé
2020-10-05 13:36 ` Richard Henderson
2020-09-27 16:39 ` [PATCH 2/2] hw/mips: Simplify code using ROUND_UP(INITRD_PAGE_SIZE) Philippe Mathieu-Daudé
2020-10-05 13:37 ` Richard Henderson [this message]
2020-10-05 7:41 ` [PATCH 0/2] hw/mips: Code simplifications Philippe Mathieu-Daudé
2020-10-07 13:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa3c770e-b1c5-261c-e0e0-42fb84677600@linaro.org \
--to=richard.henderson@linaro.org \
--cc=aleksandar.qemu.devel@gmail.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=chenhc@lemote.com \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=zltjiangshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).