qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com,
	jan.kiszka@siemens.com, armbru@redhat.com, agraf@suse.de,
	blauwirbel@gmail.com, yamahata@valinux.co.jp,
	alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com,
	mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com,
	afaerber@suse.de, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH v1 11/13] q35: automatically load the q35 dsdt table
Date: Mon, 29 Oct 2012 22:11:29 -0400	[thread overview]
Message-ID: <aa3fcc6b6086d5228c6e43eac13d7e404005c302.1351561225.git.jbaron@redhat.com> (raw)
In-Reply-To: <cover.1351561225.git.jbaron@redhat.com>

From: Jason Baron <jbaron@redhat.com>

Automatically, locate the required q35 dsdt table on load. Otherwise we error
out. This could be done in the bios, but its harder to produce a good error
message.

Signed-off-by: Jason Baron <jbaron@redhat.com>
---
 hw/pc.c     |   19 +++++++++++++++++++
 hw/pc.h     |    2 ++
 hw/pc_q35.c |    7 +++++++
 3 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/hw/pc.c b/hw/pc.c
index af1a076..743d771 100644
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -1153,3 +1153,22 @@ void ioapic_init_gsi(GSIState *gsi_state, const char *parent_name)
         gsi_state->ioapic_irq[i] = qdev_get_gpio_in(dev, i);
     }
 }
+
+int find_and_load_dsdt(const char *dsdt_name)
+{
+    char *filename;
+    char buf[1024];
+
+    filename = qemu_find_file(QEMU_FILE_TYPE_BIOS, dsdt_name);
+    if (!filename) {
+        return -1;
+    }
+    snprintf(buf, sizeof(buf), "file=%s", filename);
+    g_free(filename);
+    if (acpi_table_add(buf) < 0) {
+        fprintf(stderr, "Wrong acpi table provided\n");
+        return -1;
+    }
+
+    return 0;
+}
diff --git a/hw/pc.h b/hw/pc.h
index e1bf2fc..1a3db90 100644
--- a/hw/pc.h
+++ b/hw/pc.h
@@ -187,5 +187,7 @@ void pc_system_firmware_init(MemoryRegion *rom_memory);
 #define E820_UNUSABLE   5
 
 int e820_add_entry(uint64_t, uint64_t, uint32_t);
+int find_and_load_dsdt(const char *dsdt_name);
+
 
 #endif
diff --git a/hw/pc_q35.c b/hw/pc_q35.c
index 1f31486..a9a7f6c 100644
--- a/hw/pc_q35.c
+++ b/hw/pc_q35.c
@@ -232,6 +232,13 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
     qemu_irq *i8259;
     int i;
 
+    /* let's first see if we can find the proper dsdt */
+    if (find_and_load_dsdt("q35-acpi-dsdt.aml")) {
+        fprintf(stderr, "Couldn't find q35 dsdt table!\n"
+                        "Try updating your bios.\n");
+        exit(1);
+    }
+
     pc_cpus_init(cpu_model);
 
     kvmclock_create();
-- 
1.7.1

  parent reply	other threads:[~2012-10-30  2:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30  2:11 [Qemu-devel] [PATCH v1 00/13] q35 patches for pci tree Jason Baron
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 01/13] pc/piix_pci: factor out smram/pam logic Jason Baron
2012-10-30 19:07   ` Anthony Liguori
2012-10-30 20:26     ` Andreas Färber
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 03/13] blockdev: Introduce QEMUMachine->default_drive_if Jason Baron
2012-10-30 19:08   ` Anthony Liguori
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 02/13] Back out add of i21154 Jason Baron
2012-10-31  9:54   ` Michael S. Tsirkin
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 04/13] blockdev: Introduce IF_AHCI Jason Baron
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 06/13] pc: Move ioapic_init() from pc_piix.c to pc.c Jason Baron
2012-10-31 10:02   ` Michael S. Tsirkin
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 05/13] pc, pc_piix: split out pc nic initialization Jason Baron
2012-10-30 19:09   ` Anthony Liguori
2012-10-31  9:57   ` Michael S. Tsirkin
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 07/13] q35: Introduce q35 pc based chipset emulator Jason Baron
2012-10-30 19:18   ` Anthony Liguori
2012-10-31 10:04     ` Michael S. Tsirkin
2012-10-31 12:53       ` Anthony Liguori
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 09/13] q35: Add kvmclock support Jason Baron
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 08/13] q35: Suppress SMM BIOS initialization under KVM Jason Baron
2012-10-30  2:11 ` Jason Baron [this message]
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 10/13] Add a fallback bios file search, if -L fails Jason Baron
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 12/13] q35: fill in usb pci slots with -usb Jason Baron
2012-10-30  6:34   ` Gerd Hoffmann
2012-10-30 15:19     ` Jason Baron
2012-10-30 16:19       ` Gerd Hoffmann
2012-10-30 18:00         ` Jason Baron
2012-10-30  2:11 ` [Qemu-devel] [PATCH v1 13/13] Fixup q35/ich9 Licenses Jason Baron
2012-10-31  8:59   ` Michael S. Tsirkin
2012-10-31  9:34     ` Isaku Yamahata
2012-10-31  9:57       ` Michael S. Tsirkin
2012-10-30 19:20 ` [Qemu-devel] [PATCH v1 00/13] q35 patches for pci tree Anthony Liguori
2012-10-31  8:42   ` Michael S. Tsirkin
2012-10-31 12:55     ` Anthony Liguori
2012-10-31 14:42       ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa3fcc6b6086d5228c6e43eac13d7e404005c302.1351561225.git.jbaron@redhat.com \
    --to=jbaron@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=juzhang@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mkletzan@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).