From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PULL 08/30] target/arm: Add ptw_idx to S1Translate
Date: Tue, 1 Nov 2022 17:57:16 +0100 [thread overview]
Message-ID: <aa4463f4-30d8-cb84-b38f-9d359974e543@linaro.org> (raw)
In-Reply-To: <425d6322-3cab-01da-e6c6-f8e07564e7c0@linaro.org>
On 1/11/22 11:10, Philippe Mathieu-Daudé wrote:
> On 1/11/22 00:14, Philippe Mathieu-Daudé wrote:
>> On 25/10/22 18:39, Peter Maydell wrote:
>>> From: Richard Henderson <richard.henderson@linaro.org>
>>>
>>> Hoist the computation of the mmu_idx for the ptw up to
>>> get_phys_addr_with_struct and get_phys_addr_twostage.
>>> This removes the duplicate check for stage2 disabled
>>> from the middle of the walk, performing it only once.
>>>
>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>> Tested-by: Alex Bennée <alex.bennee@linaro.org>
>>> Message-id: 20221024051851.3074715-3-richard.henderson@linaro.org
>>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>>> ---
>>> target/arm/ptw.c | 71 ++++++++++++++++++++++++++++++++++++------------
>>> 1 file changed, 54 insertions(+), 17 deletions(-)
>> Since this commit I can not boot Trusted Firmware on the SBSA-ref
>> machine.
>
> Do we need to set in_ptw_idx in get_phys_addr_with_secure()?
I opened https://gitlab.com/qemu-project/qemu/-/issues/1293 to track.
next prev parent reply other threads:[~2022-11-01 17:19 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-25 16:39 [PULL 00/30] target-arm queue Peter Maydell
2022-10-25 16:39 ` [PULL 01/30] target/arm: Implement FEAT_E0PD Peter Maydell
2022-10-25 16:39 ` [PULL 02/30] hw/arm/virt: Fix devicetree warnings about the virtio-iommu node Peter Maydell
2022-10-25 16:39 ` [PULL 03/30] target/arm: honor HCR_E2H and HCR_TGE in arm_excp_unmasked() Peter Maydell
2022-10-25 16:39 ` [PULL 04/30] hw/core/resettable: fix reset level counting Peter Maydell
2022-10-25 16:39 ` [PULL 05/30] hw/hyperv/hyperv.c: Use device_cold_reset() instead of device_legacy_reset() Peter Maydell
2022-10-25 16:39 ` [PULL 06/30] target/imx: reload cmp timer outside of the reload ptimer transaction Peter Maydell
2022-10-25 16:39 ` [PULL 07/30] target/arm: Introduce regime_is_stage2 Peter Maydell
2022-10-25 16:39 ` [PULL 08/30] target/arm: Add ptw_idx to S1Translate Peter Maydell
2022-10-31 23:14 ` Philippe Mathieu-Daudé
2022-11-01 10:10 ` Philippe Mathieu-Daudé
2022-11-01 16:57 ` Philippe Mathieu-Daudé [this message]
2022-10-25 16:39 ` [PULL 09/30] target/arm: Add isar predicates for FEAT_HAFDBS Peter Maydell
2022-10-25 16:39 ` [PULL 10/30] target/arm: Extract HA and HD in aa64_va_parameters Peter Maydell
2022-10-25 16:39 ` [PULL 11/30] target/arm: Move S1_ptw_translate outside arm_ld[lq]_ptw Peter Maydell
2022-10-25 16:39 ` [PULL 12/30] target/arm: Add ARMFault_UnsuppAtomicUpdate Peter Maydell
2022-10-25 16:39 ` [PULL 13/30] target/arm: Remove loop from get_phys_addr_lpae Peter Maydell
2022-10-25 16:39 ` [PULL 14/30] target/arm: Fix fault reporting in get_phys_addr_lpae Peter Maydell
2022-10-25 16:39 ` [PULL 15/30] target/arm: Don't shift attrs " Peter Maydell
2022-10-25 16:39 ` [PULL 16/30] target/arm: Consider GP an attribute " Peter Maydell
2022-10-25 16:39 ` [PULL 17/30] target/arm: Tidy merging of attributes from descriptor and table Peter Maydell
2022-10-25 16:39 ` [PULL 18/30] target/arm: Implement FEAT_HAFDBS, access flag portion Peter Maydell
2022-10-25 16:39 ` [PULL 19/30] target/arm: Implement FEAT_HAFDBS, dirty bit portion Peter Maydell
2022-10-25 16:39 ` [PULL 20/30] target/arm: Use the max page size in a 2-stage ptw Peter Maydell
2022-10-25 16:39 ` [PULL 21/30] reset: allow registering handlers that aren't called by snapshot loading Peter Maydell
2022-10-25 16:39 ` [PULL 22/30] device-tree: add re-randomization helper function Peter Maydell
2022-10-25 16:39 ` [PULL 23/30] x86: do not re-randomize RNG seed on snapshot load Peter Maydell
2022-10-25 16:39 ` [PULL 24/30] arm: re-randomize rng-seed on reboot Peter Maydell
2022-10-25 16:39 ` [PULL 25/30] riscv: " Peter Maydell
2022-10-25 16:39 ` [PULL 26/30] m68k/virt: do not re-randomize RNG seed on snapshot load Peter Maydell
2022-10-25 16:39 ` [PULL 27/30] m68k/q800: " Peter Maydell
2022-10-25 16:39 ` [PULL 28/30] mips/boston: re-randomize rng-seed on reboot Peter Maydell
2022-10-25 16:39 ` [PULL 29/30] openrisc: " Peter Maydell
2022-10-25 16:39 ` [PULL 30/30] rx: " Peter Maydell
2022-10-26 14:49 ` [PULL 00/30] target-arm queue Stefan Hajnoczi
2022-10-26 15:26 ` Jason A. Donenfeld
2022-10-26 14:51 ` Stefan Hajnoczi
2022-10-27 10:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa4463f4-30d8-cb84-b38f-9d359974e543@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).