From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45DDCC761A6 for ; Sat, 1 Apr 2023 01:39:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1piQCK-0001Cm-7j; Fri, 31 Mar 2023 21:38:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piQCI-0001A7-ML for qemu-devel@nongnu.org; Fri, 31 Mar 2023 21:38:26 -0400 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piQCG-0007Rj-TK for qemu-devel@nongnu.org; Fri, 31 Mar 2023 21:38:26 -0400 Received: by mail-pg1-x52d.google.com with SMTP id y35so14495802pgl.4 for ; Fri, 31 Mar 2023 18:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680313103; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qMm3xBAVSDpsL76gwomXVIF+8DHQX1Y2MtrdPm6elHw=; b=TuFmkTOeCA3BqNpWmIrlHNtXOM5nRW385BZPh9IrhwSxXDXRBUtZFJKuh85QKsqySS x34ACWewit6zxOnKNWyQ1V4UQ9Kdr9/vRc2fIQ6vDxwMeyfaD8GooAqwuy2bH7rDnToG xw9PTF7w5OelJOaHE7CQ4mUbljT+MQAy/6P2eZ6p2yuAe+S5PY3HRM0eHJAuWkqJKyLa AxpKO1Q/+AF3wlBoWquwR2G5ReiyD0LM9LEO5KUHr5GBzzzAnLDgzIg3sY6u+uZSQ5Fo Y+BXox4PEhqLujDk2YzFFl1GEkbbUhQuGm1KbDk9sPuptP+q2sAiuMwi69PekzS1BZI1 aDPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680313103; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qMm3xBAVSDpsL76gwomXVIF+8DHQX1Y2MtrdPm6elHw=; b=ZOjtOPjWeBB36gSJ0aY8IXmqrMbhlDDacDO8wgeewR0CBMW56GQsCg2Ec/Vb9FU8bf MOoEcxHaeb4JoseAnVcqQRMlVnokgPT6Q2KmoIvYxA2Y0jPQSoUXcySeqBnXrZkaPGWw WMF0F2p3i14ECBP4GyIy7d9piZcnPzLOJ3Ab68kSVCys7VxM7GnjOMEpvLIXc3ZzSslu Nv7XtTVGfcelO+biuGpsbAwDtxJlBoC1xgSFzOVK2fmB8all2YzvQlFaLnFZrakBF7yc /OcTNvrA8B9ihEo49vtU7e0MlJUTHiGZcHoMmTzOJYKtlxNF+GKEiVMFg0rYTn/iURQX GpPA== X-Gm-Message-State: AAQBX9fUkNtglf1cc5NnokGutKAF+xB7HO7cK3P86tWJeY3s+hXKUVPK Ujv6UyfCnQ+fUQq+WQncCNz6WA== X-Google-Smtp-Source: AKy350Z+ODPeAAVamb1kJDD7tVhddf5ngv3kb3vG7CQAauN3VhqNrea5qU6mGc3vaOAbZFsqVdYSlA== X-Received: by 2002:a62:1c04:0:b0:625:d697:c386 with SMTP id c4-20020a621c04000000b00625d697c386mr26870632pfc.22.1680313103024; Fri, 31 Mar 2023 18:38:23 -0700 (PDT) Received: from ?IPV6:2602:ae:1541:f901:b714:1fce:85fa:2fc7? ([2602:ae:1541:f901:b714:1fce:85fa:2fc7]) by smtp.gmail.com with ESMTPSA id n2-20020aa79042000000b0062ddfce5cdbsm2237369pfo.45.2023.03.31.18.38.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 18:38:22 -0700 (PDT) Message-ID: Date: Fri, 31 Mar 2023 18:38:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v4 5/8] accel/tcg: Fix overwrite problems of tcg_cflags Content-Language: en-US From: Richard Henderson To: Weiwei Li , qemu-riscv@nongnu.org, qemu-devel@nongnu.org Cc: palmer@dabbelt.com, alistair.francis@wdc.com, bin.meng@windriver.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, wangjunqiang@iscas.ac.cn, lazyparser@gmail.com References: <20230331150609.114401-1-liweiwei@iscas.ac.cn> <20230331150609.114401-6-liweiwei@iscas.ac.cn> <054b85f3-5ae8-9215-f9af-d3c55126e552@linaro.org> <6c0ea9e4-4f5b-9384-7b48-ded2998f9204@linaro.org> In-Reply-To: <6c0ea9e4-4f5b-9384-7b48-ded2998f9204@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::52d; envelope-from=richard.henderson@linaro.org; helo=mail-pg1-x52d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 3/31/23 18:33, Richard Henderson wrote: > On 3/31/23 18:18, Richard Henderson wrote: >> On 3/31/23 08:06, Weiwei Li wrote: >>> CPUs often set CF_PCREL in tcg_cflags before qemu_init_vcpu(), in which >>> tcg_cflags will be overwrited by tcg_cpu_init_cflags(). >>> >>> Signed-off-by: Weiwei Li >>> Signed-off-by: Junqiang Wang >>> --- >>>   accel/tcg/tcg-accel-ops.c | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> Reviewed-by: Richard Henderson > > Fixes: 4be790263ffc ("accel/tcg: Replace `TARGET_TB_PCREL` with `CF_PCREL`") Queued to tcg-next. r~