From: Paolo Bonzini <pbonzini@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: lvivier@redhat.com, thuth@redhat.com, pkrempa@redhat.com,
berrange@redhat.com, Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, libvir-list@redhat.com, armbru@redhat.com,
jasowang@redhat.com, qemu-devel@nongnu.org, mreitz@redhat.com,
kraxel@redhat.com
Subject: Re: [PATCH 00/18] qapi/qom: QAPIfy object-add
Date: Thu, 3 Dec 2020 19:01:34 +0100 [thread overview]
Message-ID: <aa5e529c-105c-341b-b80d-9b30cc29a0d1@redhat.com> (raw)
In-Reply-To: <20201203174316.GC5409@merkur.fritz.box>
On 03/12/20 18:43, Kevin Wolf wrote:
> I think I'd want to do step 2 and 3 combined, because converting
> user-creatable objects to oc->configure means manually writing the
> configure function that will be generated from QAPI in step 3. Writing
> code just to throw it away isn't my favourite pastime.
It would only be a couple lines of extra code, but yeah you don't have
to do it. It still is clearer to show the steps one by one as they are
logically separate and it shows what (modulo inlining) the generated
code ends up doing.
That said having no setter might simplify the introduction of field
properties too (no allow_set to worry about); perhaps that's a good
reason to do the oc->configure conversion earlier rather than later,
especially if QAPI code generation ends up taking a bit longer.
Another good reason is to make sure the API is stable before moving to
generated code, especially with respect to inheritance.
Paolo
next prev parent reply other threads:[~2020-12-03 18:04 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:25 [PATCH 00/18] qapi/qom: QAPIfy object-add Kevin Wolf
2020-11-30 12:25 ` [PATCH 01/18] qapi/qom: Add ObjectOptions for iothread Kevin Wolf
2020-11-30 15:00 ` Paolo Bonzini
2020-11-30 15:54 ` Kevin Wolf
2020-11-30 12:25 ` [PATCH 02/18] qapi/qom: Add ObjectOptions for authz-* Kevin Wolf
2020-11-30 12:25 ` [PATCH 03/18] qapi/qom: Add ObjectOptions for cryptodev-* Kevin Wolf
2020-11-30 12:25 ` [PATCH 04/18] qapi/qom: Add ObjectOptions for dbus-vmstate Kevin Wolf
2020-11-30 12:25 ` [PATCH 05/18] qapi/qom: Add ObjectOptions for memory-backend-* Kevin Wolf
2020-11-30 12:25 ` [PATCH 06/18] qapi/qom: Add ObjectOptions for rng-*, deprecate 'opened' Kevin Wolf
2020-11-30 12:25 ` [PATCH 07/18] qapi/qom: Add ObjectOptions for throttle-group Kevin Wolf
2020-11-30 12:25 ` [PATCH 08/18] qapi/qom: Add ObjectOptions for secret*, deprecate 'loaded' Kevin Wolf
2020-11-30 12:25 ` [PATCH 09/18] qapi/qom: Add ObjectOptions for tls-*, " Kevin Wolf
2020-11-30 12:25 ` [PATCH 10/18] qapi/qom: Add ObjectOptions for can-* Kevin Wolf
2020-11-30 12:25 ` [PATCH 11/18] qapi/qom: Add ObjectOptions for colo-compare Kevin Wolf
2020-11-30 12:25 ` [PATCH 12/18] qapi/qom: Add ObjectOptions for filter-* Kevin Wolf
2020-11-30 12:25 ` [PATCH 13/18] qapi/qom: Add ObjectOptions for pr-manager-helper Kevin Wolf
2020-11-30 12:25 ` [PATCH 14/18] qapi/qom: Add ObjectOptions for sev-guest Kevin Wolf
2020-11-30 12:25 ` [PATCH 15/18] qapi/qom: Add ObjectOptions for input-* Kevin Wolf
2020-11-30 12:25 ` [PATCH 16/18] tests: Drop 'props' from object-add calls Kevin Wolf
2020-11-30 12:25 ` [PATCH 17/18] qapi/qom: Drop deprecated 'props' from object-add Kevin Wolf
2020-11-30 12:25 ` [PATCH 18/18] qapi/qom: QAPIfy object-add Kevin Wolf
2020-11-30 14:58 ` [PATCH 00/18] " Paolo Bonzini
2020-11-30 15:30 ` Daniel P. Berrangé
2020-11-30 16:13 ` Kevin Wolf
2020-11-30 16:52 ` Daniel P. Berrangé
2020-11-30 16:32 ` Paolo Bonzini
2020-12-01 8:36 ` Markus Armbruster
2020-11-30 15:46 ` Kevin Wolf
2020-11-30 16:57 ` Paolo Bonzini
2020-11-30 18:10 ` Kevin Wolf
2020-11-30 19:35 ` Paolo Bonzini
2020-12-01 16:20 ` Kevin Wolf
2020-12-01 17:16 ` Paolo Bonzini
2020-12-01 18:28 ` Eduardo Habkost
2020-12-01 19:35 ` Kevin Wolf
2020-12-01 21:23 ` Paolo Bonzini
2020-12-01 22:08 ` Eduardo Habkost
2020-12-02 9:30 ` Paolo Bonzini
2020-12-02 10:38 ` Kevin Wolf
2020-12-02 12:30 ` Paolo Bonzini
2020-12-02 12:51 ` Eduardo Habkost
2020-12-02 13:26 ` Paolo Bonzini
2020-12-02 13:54 ` Eduardo Habkost
2020-12-02 15:17 ` Kevin Wolf
2020-12-02 16:05 ` Eduardo Habkost
2020-12-02 17:35 ` Kevin Wolf
2020-12-02 19:45 ` Eduardo Habkost
2020-12-03 6:46 ` Gerd Hoffmann
2020-12-03 14:58 ` Eduardo Habkost
2020-12-03 11:11 ` Paolo Bonzini
2020-12-03 15:15 ` Kevin Wolf
2020-12-03 16:50 ` Paolo Bonzini
2020-12-03 17:43 ` Kevin Wolf
2020-12-03 18:01 ` Paolo Bonzini [this message]
2020-12-03 17:52 ` Eduardo Habkost
2020-12-03 18:10 ` Paolo Bonzini
2020-12-03 18:19 ` Eduardo Habkost
2020-12-02 10:27 ` Kevin Wolf
2020-12-02 12:41 ` Paolo Bonzini
2020-11-30 18:58 ` Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa5e529c-105c-341b-b80d-9b30cc29a0d1@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).