From: Richard Henderson <richard.henderson@linaro.org>
To: Xiaojuan Yang <yangxiaojuan@loongson.cn>, qemu-devel@nongnu.org
Cc: gaosong@loongson.cn, maobibo@loongson.cn,
mark.cave-ayland@ilande.co.uk, f4bug@amsat.org,
peter.maydell@linaro.org
Subject: Re: [PATCH v2 3/3] hw/intc: Fix LoongArch ipi device emulation
Date: Wed, 28 Sep 2022 19:42:48 -0700 [thread overview]
Message-ID: <aa5e61d8-0074-9c56-1da3-da120d5ee185@linaro.org> (raw)
In-Reply-To: <20220927061225.3566554-4-yangxiaojuan@loongson.cn>
On 9/26/22 23:12, Xiaojuan Yang wrote:
> In ipi_send function, it should not to set irq before
> writing data to dest cpu iocsr space, as the irq will
> trigger after data writing.
>
> Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
> ---
> hw/intc/loongarch_ipi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c
> index 4f3c58f872..aa4bf9eb74 100644
> --- a/hw/intc/loongarch_ipi.c
> +++ b/hw/intc/loongarch_ipi.c
> @@ -88,7 +88,6 @@ static void ipi_send(uint64_t val)
> cs = qemu_get_cpu(cpuid);
> cpu = LOONGARCH_CPU(cs);
> env = &cpu->env;
> - loongarch_cpu_set_irq(cpu, IRQ_IPI, 1);
> address_space_stl(&env->address_space_iocsr, 0x1008,
> data, MEMTXATTRS_UNSPECIFIED, NULL);
>
Did you mean to move the call below the set?
Otherwise, where does the irq get raised?
r~
next prev parent reply other threads:[~2022-09-29 2:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 6:12 [PATCH v2 0/3] Add memmap and fix bugs for LoongArch Xiaojuan Yang
2022-09-27 6:12 ` [PATCH v2 1/3] hw/loongarch: Add memmap for LoongArch virt machine Xiaojuan Yang
2022-09-29 2:25 ` Richard Henderson
2022-09-27 6:12 ` [PATCH v2 2/3] hw/intc: Fix LoongArch extioi function Xiaojuan Yang
2022-09-29 2:38 ` Richard Henderson
2022-09-27 6:12 ` [PATCH v2 3/3] hw/intc: Fix LoongArch ipi device emulation Xiaojuan Yang
2022-09-29 2:42 ` Richard Henderson [this message]
2022-09-29 3:23 ` yangxiaojuan
2022-09-29 4:12 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa5e61d8-0074-9c56-1da3-da120d5ee185@linaro.org \
--to=richard.henderson@linaro.org \
--cc=f4bug@amsat.org \
--cc=gaosong@loongson.cn \
--cc=maobibo@loongson.cn \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).